Skip to content

Combine criterion and new criterion tests in test_jit. #43958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gchanan wants to merge 3 commits into from
Closed

Combine criterion and new criterion tests in test_jit. #43958

gchanan wants to merge 3 commits into from

Conversation

@gchanan
Copy link
Contributor

@gchanan gchanan commented Sep 1, 2020 •
edited
Loading

Stack from ghstack:

There is not any difference between these tests (I'm merging them), so let's merge them in the JIT as well.

Differential Revision: D23452337

@gchanan
Combine criterion and new criterion tests in test_jit.
897148b 
There is not any difference between these tests (I'm merging them), so let's merge them in the JIT as well.
gchanan added a commit that referenced this pull request Sep 1, 2020
@gchanan
Combine criterion and new criterion tests in test_jit.
d31add5 
There is not any difference between these tests (I'm merging them), so let's merge them in the JIT as well.

ghstack-source-id: bfbf0d0
Pull Request resolved: #43958
@dr-ci
Copy link

dr-ci bot commented Sep 1, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 2de41ef (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 19 times.

@gchanan
Update on "Combine criterion and new criterion tests in test_jit."
e21439e 
There is not any difference between these tests (I'm merging them), so let's merge them in the JIT as well.

Differential Revision: [D23452337](https://our.internmc.facebook.com/intern/diff/D23452337)

[ghstack-poisoned]
gchanan added a commit that referenced this pull request Sep 2, 2020
@gchanan
Combine criterion and new criterion tests in test_jit.
c1c46e6 
There is not any difference between these tests (I'm merging them), so let's merge them in the JIT as well.

ghstack-source-id: 5a64c96
Pull Request resolved: #43958
@gchanan
Update on "Combine criterion and new criterion tests in test_jit."
2de41ef 
There is not any difference between these tests (I'm merging them), so let's merge them in the JIT as well.

Differential Revision: [D23452337](https://our.internmc.facebook.com/intern/diff/D23452337)

[ghstack-poisoned]
@gchanan gchanan mentioned this pull request Sep 9, 2020
Closed
@codecov
Copy link

codecov bot commented Sep 9, 2020 •
edited
Loading

Codecov Report

Merging #43958 into gh/gchanan/312/base will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           gh/gchanan/312/base   #43958   +/-   ##
====================================================
  Coverage                67.99%   68.00%           
====================================================
  Files                      382      382           
  Lines                    49380    49380           
====================================================
+ Hits                     33578    33579    +1     
+ Misses                   15802    15801    -1
Impacted Files Coverage Δ
torch/testing/_internal/common_nn.py 83.08% <ø> (ø)
...ch/testing/_internal/common_methods_invocations.py 92.13% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acce55...2de41ef. Read the comment docs.

@gchanan
Copy link
Contributor Author

gchanan commented Sep 9, 2020

I'm not really sure what the issue with the CTCLoss tests are but I'll file an issue for it.

@gchanan gchanan requested a review from mruberry September 9, 2020 21:19
@gchanan gchanan mentioned this pull request Sep 9, 2020
Closed
mruberry
mruberry approved these changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue sounds good.

@gchanan gchanan mentioned this pull request Sep 10, 2020
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 10, 2020

@gchanan merged this pull request in fa158c4.

@gchanan gchanan mentioned this pull request Sep 10, 2020
Closed
@gchanan
Copy link
Contributor Author

gchanan commented Sep 10, 2020

I'm not really sure what the issue with the CTCLoss tests are but I'll file an issue for it.

#44503

@gchanan gchanan mentioned this pull request Sep 10, 2020
Closed
@facebook-github-bot facebook-github-bot deleted the gh/gchanan/312/head branch September 14, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gchanan @facebook-github-bot @mruberry