Skip to content

[TensorExpr] Check statements in test_kernel.cpp #43911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
asuhan wants to merge 1 commit into from
Closed

[TensorExpr] Check statements in test_kernel.cpp #43911

asuhan wants to merge 1 commit into from

Conversation

@asuhan
Copy link
Contributor

@asuhan asuhan commented Aug 31, 2020

Summary: Check statements and fix all the warnings.

Test Plan: test_tensorexpr

@asuhan
Copy link
Contributor Author

asuhan commented Aug 31, 2020 •
edited
Loading

Wait for #43905 to land first. I'll rebase once that happens and get rid of the first commit.

@asuhan asuhan requested a review from ZolotukhinM August 31, 2020 21:47
ZolotukhinM
ZolotukhinM approved these changes Aug 31, 2020
View reviewed changes
Copy link

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for paying our technical debt! I have some comments inline, but I'm not opposed to landing this as-is.

@dr-ci
Copy link

dr-ci bot commented Aug 31, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 9fd6f96 (more details on the Dr. CI page):

  • 1/9 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 8/9 broken upstream at merge base da32bf4 since Aug 31

🚧 8 ongoing upstream failures:

These were probably caused by upstream breakages that are not fixed yet:

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 27 times.

@asuhan asuhan force-pushed the asuhan/fix_warnings branch from 619adcd to 8964c16 Compare August 31, 2020 22:46
@asuhan
Copy link
Contributor Author

asuhan commented Aug 31, 2020

@ZolotukhinM I've relaxed the checks quite a bit due to different behaviors between backends. I'd have liked to use captured variables and be more precise, but I didn't manage to get them to work in our setup.

@asuhan asuhan force-pushed the asuhan/fix_warnings branch from 8964c16 to dc49ab1 Compare September 1, 2020 01:22
facebook-github-bot
facebook-github-bot reviewed Sep 1, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asuhan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@asuhan
[TensorExpr] Check statements in test_kernel.cpp
9fd6f96 
Summary: Check statements and fix all the warnings.

Test Plan: test_tensorexpr

Reviewers:

Subscribers:

Tasks:

Tags:
@asuhan asuhan force-pushed the asuhan/fix_warnings branch from dc49ab1 to 9fd6f96 Compare September 1, 2020 02:38
facebook-github-bot
facebook-github-bot reviewed Sep 1, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asuhan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 1, 2020

@asuhan merged this pull request in 85d91a3.

@asuhan asuhan deleted the asuhan/fix_warnings branch September 1, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

+1 more reviewer

@ZolotukhinM ZolotukhinM ZolotukhinM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asuhan @facebook-github-bot @ZolotukhinM @mruberry