Skip to content

Conversation

@asuhan
Copy link
Contributor

@asuhan asuhan commented Aug 31, 2020

Summary: Reduce input size, skip the dtype conversion.

Test Plan: test_tensorexpr --gtest_filter=TensorExprTest.KernelSum*

Summary: Reduce input size, skip the dtype conversion.

Test Plan: test_tensorexpr --gtest_filter=TensorExprTest.KernelSum*

Reviewers:

Subscribers:

Tasks:

Tags:
@asuhan asuhan requested a review from nickgg August 31, 2020 20:15
Copy link
Contributor

@nickgg nickgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💨

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asuhan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #43905 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43905      +/-   ##
==========================================
- Coverage   69.32%   69.32%   -0.01%     
==========================================
  Files         378      378              
  Lines       46787    46787              
==========================================
- Hits        32436    32435       -1     
- Misses      14351    14352       +1     
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7bae5b...52f1f07. Read the comment docs.

@dr-ci
Copy link

dr-ci bot commented Sep 1, 2020

💊 CI failures summary and remediations

As of commit 52f1f07 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

@asuhan merged this pull request in deb5fde.

@asuhan asuhan deleted the asuhan/faster_test branch September 1, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants