Skip to content

Conversation

@anderspapitto
Copy link
Contributor

No description provided.

@anderspapitto
Copy link
Contributor Author

(Do not merge yet. The code is complete and reviewable but tests in the onnx-fb-universe repo are upcoming.)

This comment was marked as off-topic.

@anderspapitto anderspapitto force-pushed the gru branch 2 times, most recently from 2705ea5 to f463638 Compare January 3, 2018 20:27

This comment was marked as off-topic.

This comment was marked as off-topic.

@dzhulgakov
Copy link
Collaborator

Also please fix lint (as the CI is failing). Structure wise looks good (though the circular dependencies are starting to get messy)

@ezyang
Copy link
Contributor

ezyang commented Jan 6, 2018

Lint still broken.

Note that flake8 on the box your dev'ing on is a special snowflake and doesn't actually apply the correct rules. I often pip install flake8 to get a more sane copy.

@anderspapitto
Copy link
Contributor Author

any more comments? I think this is ready to ship

@soumith soumith merged commit a3f4fa2 into pytorch:master Jan 9, 2018
@soumith
Copy link
Contributor

soumith commented Jan 9, 2018

thanks @anderspapitto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants