Skip to content

Add __complex__ #43844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zasdfgbnm wants to merge 5 commits into from
Closed

Add __complex__ #43844

zasdfgbnm wants to merge 5 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Aug 29, 2020 •
edited
Loading

fixes #43833

@zasdfgbnm zasdfgbnm requested review from anjali411 and ngimel August 29, 2020 20:31
@zasdfgbnm zasdfgbnm mentioned this pull request Aug 29, 2020
Closed
@ngimel
Copy link
Collaborator

ngimel commented Aug 29, 2020

cool! does it fix #43579 by any chance?

@dr-ci
Copy link

dr-ci bot commented Aug 29, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit ad6abaf (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 6 times.

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Aug 30, 2020

@ngimel Tried and no, this doesn't

@codecov
Copy link

codecov bot commented Aug 30, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ab3ea95). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #43844   +/-   ##
=========================================
  Coverage          ?   69.31%           
=========================================
  Files             ?      378           
  Lines             ?    46745           
  Branches          ?        0           
=========================================
  Hits              ?    32403           
  Misses            ?    14342           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab3ea95...ad6abaf. Read the comment docs.

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Aug 30, 2020

Tests are passing

facebook-github-bot
facebook-github-bot reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Aug 31, 2020
@zasdfgbnm zasdfgbnm deleted the fix-complex-type-cast branch August 31, 2020 18:58
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 31, 2020

@ngimel merged this pull request in 4ef12be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

@anjali411 anjali411 anjali411 approved these changes

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.tensor does not support list of complex tensor

7 participants

@zasdfgbnm @ngimel @facebook-github-bot @anjali411 @pytorchbot @mruberry