Skip to content

addmm/addmv should accept complex alpha and beta #43827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zasdfgbnm wants to merge 2 commits into from
Closed

addmm/addmv should accept complex alpha and beta #43827

zasdfgbnm wants to merge 2 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Aug 29, 2020

No description provided.

@zasdfgbnm zasdfgbnm requested review from anjali411 and ngimel August 29, 2020 04:38
@ngimel
Copy link
Collaborator

ngimel commented Aug 29, 2020

Can you please add non-empty tests for complex alpha/beta? What about gemv?

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Aug 29, 2020 •
edited
Loading

@ngimel Unfortunately both addmm and addmv appear ~20 times, and alpha is never tested for correctness, and correctness of beta only appears inside empty input tests, and out is also poorly covered.

I prefer to leave this PR as is, and I will open multiple PRs to expand the test coverage.

@codecov
Copy link

codecov bot commented Aug 29, 2020 •
edited
Loading

Codecov Report

Merging #43827 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #43827   +/-   ##
=======================================
  Coverage   69.31%   69.32%           
=======================================
  Files         378      378           
  Lines       46745    46745           
=======================================
+ Hits        32403    32405    +2     
+ Misses      14342    14340    -2
Impacted Files Coverage Δ
torch/utils/_benchmark/utils/common.py 78.99% <0.00%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc52386...2049630. Read the comment docs.

@zasdfgbnm zasdfgbnm mentioned this pull request Aug 29, 2020
Closed
facebook-github-bot
facebook-github-bot reviewed Aug 29, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@anjali411 anjali411 added the module: complex Related to complex number support in PyTorch label Aug 31, 2020
@zasdfgbnm zasdfgbnm deleted the test_blas_complex branch August 31, 2020 18:58
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 31, 2020

@ngimel merged this pull request in c5d0f09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel Awaiting requested review from ngimel

@anjali411 anjali411 Awaiting requested review from anjali411

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zasdfgbnm @ngimel @facebook-github-bot @anjali411 @pytorchbot @mruberry