Skip to content

[ONNX] Update len symbolic #43824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
KsenijaS wants to merge 2 commits into from
Closed

[ONNX] Update len symbolic #43824

KsenijaS wants to merge 2 commits into from

Conversation

@KsenijaS
Copy link
Contributor

@KsenijaS KsenijaS commented Aug 29, 2020

Update len symbolic.

@dr-ci
Copy link

dr-ci bot commented Aug 29, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 596a73c (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

codecov.io: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@codecov
Copy link

codecov bot commented Aug 31, 2020 •
edited
Loading

Codecov Report

Merging #43824 into master will decrease coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43824      +/-   ##
==========================================
- Coverage   69.33%   69.33%   -0.01%     
==========================================
  Files         378      378              
  Lines       46723    46727       +4     
==========================================
+ Hits        32397    32399       +2     
- Misses      14326    14328       +2
Impacted Files Coverage Δ
torch/onnx/symbolic_opset11.py 23.02% <0.00%> (-0.11%) ⬇️
torch/onnx/symbolic_opset9.py 35.82% <50.00%> (+0.01%) ⬆️
torch/onnx/symbolic_registry.py 72.13% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6490649...596a73c. Read the comment docs.

@ailzhang ailzhang requested a review from bzinodev August 31, 2020 22:32
@ailzhang ailzhang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 31, 2020
neginraoof
neginraoof reviewed Sep 1, 2020
View reviewed changes
torch/onnx/symbolic_opset11.py

def _len(g, self):
return g.op("SequenceLength", self)
if self.type().isSubtypeOf(torch._C.ListType.ofTensors()):
Copy link
Contributor

@neginraoof neginraoof Sep 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do we have tests to cover both branches in this symbolic?

Copy link
Contributor Author

@KsenijaS KsenijaS Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, test_len covers the if branch, test_len_list covers the else branch

neginraoof
neginraoof approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@neginraoof neginraoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

shubhambhokare1
shubhambhokare1 approved these changes Sep 3, 2020
View reviewed changes
Copy link
Collaborator

@shubhambhokare1 shubhambhokare1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

facebook-github-bot
facebook-github-bot reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@KsenijaS
Copy link
Contributor Author

KsenijaS commented Sep 10, 2020

@bzinodev Can we please merge this PR? Thanks!

facebook-github-bot
facebook-github-bot reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 15, 2020

@bzinodev merged this pull request in f7cfbac.

xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@KsenijaS @xuzhao9
[ONNX] Update len symbolic (#43824)
27332f1 
Summary:
Update len symbolic.

Pull Request resolved: #43824

Reviewed By: izdeby

Differential Revision: D23575765

Pulled By: bzinodev

fbshipit-source-id: 0e5c8c8d4a5297f65e2dc43168993350f784c776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@shubhambhokare1 shubhambhokare1 shubhambhokare1 approved these changes

+2 more reviewers

@neginraoof neginraoof neginraoof approved these changes

@bzinodev bzinodev bzinodev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@KsenijaS @facebook-github-bot @neginraoof @shubhambhokare1 @bzinodev @ailzhang @pytorchbot @mruberry