Skip to content

[resubmit] Add amax/amin #43819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zasdfgbnm wants to merge 4 commits into from
Closed

[resubmit] Add amax/amin #43819

zasdfgbnm wants to merge 4 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Aug 29, 2020 •
edited by mruberry
Loading

BC-breaking Note:

This PR removes the min_values and max_values functions. These functions were undocumented and not accessible in Python.

PR Summary:

Resubmit for landing next week.

@dr-ci
Copy link

dr-ci bot commented Aug 29, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 19ce831 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 18 times.

@mruberry
Copy link
Collaborator

mruberry commented Aug 29, 2020

Does this need to wait for #43822?

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Aug 29, 2020

@mruberry Yes, I think so.

@codecov
Copy link

codecov bot commented Aug 30, 2020 •
edited
Loading

Codecov Report

Merging #43819 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #43819   +/-   ##
=======================================
  Coverage   69.32%   69.32%           
=======================================
  Files         378      378           
  Lines       46745    46749    +4     
=======================================
+ Hits        32404    32407    +3     
- Misses      14341    14342    +1
Impacted Files Coverage Δ
torch/overrides.py 98.01% <ø> (ø)
...ch/testing/_internal/common_methods_invocations.py 91.12% <ø> (ø)
torch/_tensor_docs.py 100.00% <100.00%> (ø)
torch/_torch_docs.py 100.00% <100.00%> (ø)
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5021ec8...19ce831. Read the comment docs.

facebook-github-bot
facebook-github-bot reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 31, 2020

@mruberry merged this pull request in a860be8.

@zasdfgbnm zasdfgbnm deleted the amax branch August 31, 2020 16:38
@mruberry mruberry added the module: bc-breaking Related to a BC-breaking change label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

@ngimel ngimel Awaiting requested review from ngimel

@mruberry mruberry Awaiting requested review from mruberry

Assignees

No one assigned

Labels

Merged module: bc-breaking Related to a BC-breaking change open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zasdfgbnm @mruberry @facebook-github-bot @malfet @pytorchbot