Skip to content

Updated README.md by correcting grammatical errors #43779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
manishram wants to merge 1 commit into from
Closed

Updated README.md by correcting grammatical errors #43779

manishram wants to merge 1 commit into from

Conversation

@manishram
Copy link
Contributor

@manishram manishram commented Aug 28, 2020 •
edited
Loading

Fixed grammatical errors and punctuation so that it can be more understandable.

@manishram
Updated README.md by correcting grammatical errors
b685ee0 
Fixed grammatical errors and punctuation so that it can more understandable.
@malfet malfet added module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 28, 2020
@malfet malfet requested a review from brianjo August 28, 2020 18:36
@codecov
Copy link

codecov bot commented Aug 28, 2020 •
edited
Loading

Codecov Report

Merging #43779 into master will decrease coverage by 31.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #43779       +/-   ##
===========================================
- Coverage   69.34%   38.04%   -31.31%     
===========================================
  Files         378      378               
  Lines       46698    46698               
===========================================
- Hits        32381    17764    -14617     
- Misses      14317    28934    +14617
Impacted Files Coverage Δ
torch/cuda/comm.py 0.00% <0.00%> (-100.00%) ⬇️
torch/utils/dlpack.py 0.00% <0.00%> (-100.00%) ⬇️
torch/onnx/operators.py 0.00% <0.00%> (-100.00%) ⬇️
torch/nn/backends/thnn.py 0.00% <0.00%> (-100.00%) ⬇️
torch/utils/ffi/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
torch/utils/tensorboard/_utils.py 0.00% <0.00%> (-100.00%) ⬇️
torch/utils/_benchmark/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
torch/autograd/_functions/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
torch/utils/tensorboard/_embedding.py 0.00% <0.00%> (-100.00%) ⬇️
torch/utils/tensorboard/_convert_np.py 0.00% <0.00%> (-100.00%) ⬇️
... and 224 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a7e73...b685ee0. Read the comment docs.

@manishram
Copy link
Contributor Author

manishram commented Aug 28, 2020

Hey @malfet, it was my first contribution. Can you please tell me about Codecov Report? Thanks

@malfet
Copy link
Contributor

malfet commented Aug 28, 2020

@miraliahmadli please feel free to ignore it: our system correctly detected that your change does not need any test runs as it does not change any code, but codecov is not aware of that. I will work on the change that addresses that.

brianjo
brianjo approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@brianjo brianjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love your addition of the Oxford comma. :)

facebook-github-bot
facebook-github-bot reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@dr-ci
Copy link

dr-ci bot commented Aug 28, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit b685ee0 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@malfet
Copy link
Contributor

malfet commented Aug 29, 2020

@manishram, sorry, but help with what? You change has been merged into the main trunk.

@manishram
Copy link
Contributor Author

manishram commented Aug 29, 2020 •
edited
Loading

Yeah thanks, sorry I wanted help for failed case but then I found everything got resolved and changes merged successfully. Thanks

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 29, 2020

@malfet merged this pull request in eae92b7.

@miraliahmadli
Copy link
Contributor

miraliahmadli commented Aug 29, 2020

@miraliahmadli please feel free to ignore it: our system correctly detected that your change does not need any test runs as it does not change any code, but codecov is not aware of that. I will work on the change that addresses that.

Why did you tag me, @malfet ? 😆

@malfet
Copy link
Contributor

malfet commented Aug 29, 2020

Why did you tag me, @malfet ? 😆

Sorry about that, @miraliahmadli Wrong autocomplete 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@brianjo brianjo brianjo approved these changes

Assignees

No one assigned

Labels

Merged module: docs Related to our documentation, both in docs/ and docblocks open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@manishram @malfet @facebook-github-bot @miraliahmadli @brianjo @pytorchbot @mruberry