Skip to content

Publish all_gather_object and gather_object docs #43772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mrshenli wants to merge 3 commits into from
Closed

Publish all_gather_object and gather_object docs #43772

mrshenli wants to merge 3 commits into from

Conversation

@mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Aug 28, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D23398495

mrshenli added a commit that referenced this pull request Aug 28, 2020
@mrshenli
Publish all_gather_object and gather_object docs
9c21066 
ghstack-source-id: 79d7945
Pull Request resolved: #43772
@mrshenli mrshenli requested a review from rohan-varma August 28, 2020 16:03
@mrshenli
Copy link
Contributor Author

mrshenli commented Aug 28, 2020

Indent is wrong, fixing

Screen Shot 2020-08-28 at 12 19 47 PM

Screen Shot 2020-08-28 at 12 19 56 PM

mrshenli added a commit that referenced this pull request Aug 28, 2020
@mrshenli
Publish all_gather_object and gather_object docs
7e72844 
ghstack-source-id: 10c1631
Pull Request resolved: #43772
@mrshenli
Copy link
Contributor Author

mrshenli commented Aug 28, 2020

Screen Shot 2020-08-28 at 1 11 42 PM

Screen Shot 2020-08-28 at 1 11 52 PM

rohan-varma
rohan-varma approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

mrshenli added a commit that referenced this pull request Aug 31, 2020
@mrshenli
Publish all_gather_object and gather_object docs
1406753 
ghstack-source-id: 80286ee
Pull Request resolved: #43772
@dr-ci
Copy link

dr-ci bot commented Aug 31, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 26a4083 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet:

🚧 5 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 31, 2020

@rohan-varma merged this pull request in 2f52748.

@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/224/head branch September 4, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

@pietern pietern Awaiting requested review from pietern

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

1 more reviewer

@rohan-varma rohan-varma rohan-varma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrshenli @facebook-github-bot @rohan-varma @mruberry