Fix the ELU formula in the docs #43764
Conversation
💊 CI failures summary and remediationsAs of commit 8f5a468 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Codecov Report
@@ Coverage Diff @@
## master #43764 +/- ##
=======================================
Coverage 69.34% 69.34%
=======================================
Files 378 378
Lines 46698 46698
=======================================
Hits 32381 32381
Misses 14317 14317
Continue to review full report at Codecov.
|
|
@albanD Here is a PR with the fix. Seems like the flake8 fail is unrelated to my changes. |
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
This looks great! Thanks!
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pytorchbot rebase this please |
|
@albanD Do you know the reason why this is still not merged? |
|
Hey, This is my bad. It took so long to get the internal tests to pass that it ended up dropping from my queue. |
Summary: Fixes #43389. This PR replaces the old ELU formula from the docs that yields wrong results for negative alphas with the new one that fixes the issue and relies on the cases notation which makes the formula more straightforward. Pull Request resolved: #43764 Reviewed By: ailzhang Differential Revision: D23425532 Pulled By: albanD fbshipit-source-id: d0931996e5667897d926ba4fc7a8cc66e8a66837
5 participants
Fixes #43389.
This PR replaces the old ELU formula from the docs that yields wrong results for negative alphas with the new one that fixes the issue and relies on the cases notation which makes the formula more straightforward.