Skip to content

Adds arctanh, arcsinh aliases, simplifies arc* alias dispatch #43762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mruberry wants to merge 3 commits into from
Closed

Adds arctanh, arcsinh aliases, simplifies arc* alias dispatch #43762

mruberry wants to merge 3 commits into from

Conversation

@mruberry
Copy link
Collaborator

@mruberry mruberry commented Aug 28, 2020

Adds two more "missing" NumPy aliases: arctanh and arcsinh, and simplifies the dispatch of other arc* aliases.

@mruberry mruberry requested a review from apaszke as a code owner August 28, 2020 12:01
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 28, 2020
@mruberry mruberry removed the request for review from apaszke August 28, 2020 12:04
Mike Ruberry added 2 commits August 28, 2020 05:11
@dr-ci
Copy link

dr-ci bot commented Aug 28, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3df7f93 (more details on the Dr. CI page):

  • 4/4 failures possibly* introduced in this PR
    • 2/4 non-CircleCI failure(s)

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (1/2)

Step: "Attaching workspace" (full log | diagnosis details | 🔁 rerun)

Downloading workspace layers 
Downloading workspace layers
  workflows/workspaces/47c7b01a-0c22-4443-9a27-c25188c9013c/0/029f7c72-d28f-423e-a911-cf8c2f7c2441/0/105.tar.gz - 8.4 MB
Applying workspace layers
  029f7c72-d28f-423e-a911-cf8c2f7c2441

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test1 (2/2)

Step: "Attaching workspace" (full log | diagnosis details | 🔁 rerun)

Downloading workspace layers 
Downloading workspace layers
  workflows/workspaces/47c7b01a-0c22-4443-9a27-c25188c9013c/0/029f7c72-d28f-423e-a911-cf8c2f7c2441/0/105.tar.gz - 8.4 MB
Applying workspace layers
  029f7c72-d28f-423e-a911-cf8c2f7c2441

Extra GitHub checks: 1 failed

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 3 times.

facebook-github-bot
facebook-github-bot reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mruberry
Copy link
Collaborator Author

mruberry commented Aug 28, 2020

Lint failures are in base and Windows failures are CI issues unrelated to this PR.

@mruberry mruberry mentioned this pull request Aug 28, 2020
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 28, 2020

@mruberry merged this pull request in 20abfc2.

@facebook-github-bot facebook-github-bot deleted the arc_dispatch branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mruberry @facebook-github-bot @ngimel