Use ivalue::Future in autograd engine and DistEngine. #43676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one part of #41574 to ensure we consolidate everything around ivalue::Future. I've removed the use of torch/csrc/utils/future.h from the autograd engines and used ivalue::Future instead. Differential Revision: [D23362415](https://our.internmc.facebook.com/intern/diff/D23362415/) [ghstack-poisoned]
pritamdamania87
requested review from
albanD,
apaszke,
mrshenli and
zhaojuanmao
as code owners
pritamdamania87
pushed a commit
that referenced
this pull request
Aug 27, 2020
This is one part of #41574 to ensure we consolidate everything around ivalue::Future. I've removed the use of torch/csrc/utils/future.h from the autograd engines and used ivalue::Future instead. Differential Revision: [D23362415](https://our.internmc.facebook.com/intern/diff/D23362415/) ghstack-source-id: 110808699 Pull Request resolved: #43676
💊 CI failures summary and remediationsAs of commit 3eb4b91 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
albanD
reviewed
Aug 27, 2020
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Looks quite good.
I guess that in these APIs, functions with the same name do the same thing right?
This is one part of #41574 to ensure we consolidate everything around ivalue::Future. I've removed the use of torch/csrc/utils/future.h from the autograd engines and used ivalue::Future instead. Differential Revision: [D23362415](https://our.internmc.facebook.com/intern/diff/D23362415/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Aug 27, 2020
Pull Request resolved: #43676 This is one part of #41574 to ensure we consolidate everything around ivalue::Future. I've removed the use of torch/csrc/utils/future.h from the autograd engines and used ivalue::Future instead. ghstack-source-id: 110895545 Differential Revision: [D23362415](https://our.internmc.facebook.com/intern/diff/D23362415/)
Contributor
|
This pull request has been merged in 931b8b4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This is one part of #41574 to
ensure we consolidate everything around ivalue::Future.
I've removed the use of torch/csrc/utils/future.h from the autograd engines and
used ivalue::Future instead.
Differential Revision: D23362415