Skip to content

Introduce BUILD_CAFFE2 flag #43673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
walterddr wants to merge 5 commits into from
Closed

Introduce BUILD_CAFFE2 flag #43673

walterddr wants to merge 5 commits into from

Conversation

@walterddr
Copy link
Contributor

@walterddr walterddr commented Aug 26, 2020

introduce BUILD_CAFFE2 flag. default to ON.

@dr-ci
Copy link

dr-ci bot commented Aug 26, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit aba398d (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_py3_clang5_mobile_custom_build_dynamic (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun) ❄️

cKfODLJsqOie3M4v2zuKjTFuYsCy%2BNxTuPFieUMPr1vPLYYaap64W87NHRXWC8cFLkpXLbe55e7%2BLBXpzkNZ6uJo3HWTW4PMXZR9623mIbkIiFMzbtIL%2FNJepJQoRay%2FGC5s5XxFVzq8P6PZLGhAx4V6bjq%2BdLdTJ4wsB%2BMrvaYCrnEzbY%3D&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20200901T143913Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Credential=ASIAYTIFIPBEDQSDNDO4%2F20200901%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=862de82f095b89f23ba78edaf188ded564ecb271c257e851575e8e9910bb7d5a: dial tcp 52.216.187.6:443: i/o timeout 
Parallel backend flags:  
DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-py3-clang5-android-ndk-r19c:1045c7b891104cb4fd23399eab413b6213e48aeb 
KfODLJsqOie3M4v2zuKjTFuYsCy%2BNxTuPFieUMPr1vPLYYaap64W87NHRXWC8cFLkpXLbe55e7%2BLBXpzkNZ6uJo3HWTW4PMXZR9623mIbkIiFMzbtIL%2FNJepJQoRay%2FGC5s5XxFVzq8P6PZLGhAx4V6bjq%2BdLdTJ4wsB%2BMrvaYCrnEzbY%3D&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20200901T143913Z&X-Amz-SignedHeaders=host&X-Amz-Expires=3600&X-Amz-Credential=ASIAYTIFIPBEDQSDNDO4%2F20200901%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Signature=862de82f095b89f23ba78edaf188ded564ecb271c257e851575e8e9910bb7d5a: dial tcp 52.216.187.6:443: i/o timeout
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 29 times.

@walterddr walterddr force-pushed the T72001229_add_build_caffe2_flag branch from 8480b6c to 89b485f Compare August 27, 2020 15:27
@walterddr walterddr marked this pull request as ready for review August 27, 2020 18:29
facebook-github-bot
facebook-github-bot reviewed Aug 27, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@walterddr walterddr mentioned this pull request Aug 28, 2020
Closed
@malfet malfet added module: build Build system issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 31, 2020
malfet
malfet reviewed Aug 31, 2020
View reviewed changes
.circleci/cimodel/data/simple/non_caffe2_definitions.py Outdated
)


class NonCaffe2Job:
Copy link
Contributor

@malfet malfet Aug 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about PyTorchPure build job? Also, I think it would be better to just add one more experimental node (say no-caffe2) to

pytorch/.circleci/cimodel/data/pytorch_build_data.py

Line 146 in 6ea8916

"asan": AsanConfigNode,

than create a new config altogether

@walterddr walterddr force-pushed the T72001229_add_build_caffe2_flag branch from 9061499 to 216765a Compare August 31, 2020 21:16
@walterddr walterddr force-pushed the T72001229_add_build_caffe2_flag branch from 216765a to 1c673b8 Compare August 31, 2020 21:26
@walterddr walterddr force-pushed the T72001229_add_build_caffe2_flag branch from b1aeb63 to 757662c Compare August 31, 2020 22:40
malfet
malfet requested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add if build_only or pure_torch: to

pytorch/.circleci/cimodel/data/pytorch_build_definitions.py

Line 310 in 7db7da7

if build_only:

to restrict the change to build only until tests are fixed and add #TODO comment to remove this restriction later.

Also, I would argue that in its current state it does not need to be run on every diff but only on master branch (i.e. replace XImportant with X)

@codecov
Copy link

codecov bot commented Sep 1, 2020 •
edited
Loading

Codecov Report

Merging #43673 into master will increase coverage by 0.00%.
The diff coverage is 85.07%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #43673   +/-   ##
=======================================
  Coverage   69.24%   69.25%           
=======================================
  Files         378      379    +1     
  Lines       46862    46932   +70     
=======================================
+ Hits        32451    32501   +50     
- Misses      14411    14431   +20
Impacted Files Coverage Δ
torch/overrides.py 98.01% <ø> (ø)
torch/onnx/symbolic_opset9.py 35.82% <50.00%> (+0.01%) ⬆️
torch/quantization/quantize_fx.py 66.66% <66.66%> (ø)
torch/autograd/grad_mode.py 96.36% <90.00%> (-3.64%) ⬇️
torch/_tensor_docs.py 100.00% <100.00%> (ø)
torch/_torch_docs.py 100.00% <100.00%> (ø)
torch/quantization/__init__.py 85.71% <100.00%> (+2.38%) ⬆️
torch/quantization/fx/__init__.py 100.00% <100.00%> (ø)
torch/quantization/fx/fuse.py 91.33% <100.00%> (-0.20%) ⬇️
torch/quantization/fx/quantize.py 93.35% <100.00%> (+0.11%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e4626a...aba398d. Read the comment docs.

@walterddr walterddr force-pushed the T72001229_add_build_caffe2_flag branch from e28b5e9 to aba398d Compare September 1, 2020 14:35
facebook-github-bot
facebook-github-bot reviewed Sep 1, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@walterddr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 1, 2020

@walterddr merged this pull request in 8ca3913.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

Merged module: build Build system issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@walterddr @facebook-github-bot @malfet @mruberry