Fix creating tensors with np.longlong array #4367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4363.
Fixes #4364.
When one creates an
ndarraywithnp.longlongtype, calling.dtypeon thendarrayprintsnp.int64. As far as I can tell, thenp.longlongtype is equivalent tonp.int64.However, in C code, the
NPY_LONGLONGmacro has a different value from theNPY_INT64macro.This makes it so that we treat
NPY_LONGLONGthe same way asNPY_INT64. Alternatively, to fix these issues, I could rejectNPY_LONGLONGand include better error messages but as far as I can tellnp.longlongandnp.int64are the same.Test Plan
Added a unit test case for creating tensors with
np.longlongRun the following (each script is from a separate issue) on python 2.7 and assert output is correct: