[JIT] Modify to_backend API so that it accepts wrapped modules #43612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** This commit modifies the `torch._C._jit_to_backend` function so that it accepts `ScriptModules` as inputs. It already returns `ScriptModules` (as opposed to C++ modules), so this makes sense and makes the API more intuitive. **Test Plan** Continuous integration, which includes unit tests and out-of-tree tests for custom backends. **Fixes** This commit fixes #41432. [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 7b08693 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
suo
approved these changes
Sep 14, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 29, 2020
Summary: Pull Request resolved: #43612 **Summary** This commit modifies the `torch._C._jit_to_backend` function so that it accepts `ScriptModules` as inputs. It already returns `ScriptModules` (as opposed to C++ modules), so this makes sense and makes the API more intuitive. **Test Plan** Continuous integration, which includes unit tests and out-of-tree tests for custom backends. **Fixes** This commit fixes #41432. Test Plan: Imported from OSS Reviewed By: suo, jamesr66a Differential Revision: D23339854 Pulled By: SplitInfinity fbshipit-source-id: 08ecef729c4e1e6bddf3f483276947fc3559ea88
geoffberry
pushed a commit
to geoffberry/glow
that referenced
this pull request
Nov 8, 2020
Summary: Pull Request resolved: pytorch/pytorch#43612 **Summary** This commit modifies the `torch._C._jit_to_backend` function so that it accepts `ScriptModules` as inputs. It already returns `ScriptModules` (as opposed to C++ modules), so this makes sense and makes the API more intuitive. **Test Plan** Continuous integration, which includes unit tests and out-of-tree tests for custom backends. **Fixes** This commit fixes #41432. Test Plan: Imported from OSS Reviewed By: suo, jamesr66a Differential Revision: D23339854 Pulled By: SplitInfinity fbshipit-source-id: 08ecef729c4e1e6bddf3f483276947fc3559ea88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
This commit modifies the
torch._C._jit_to_backendfunction so that itaccepts
ScriptModulesas inputs. It already returnsScriptModules(as opposed to C++ modules), so this makes sense and makes the API more
intuitive.
Test Plan
Continuous integration, which includes unit tests and out-of-tree tests
for custom backends.
Fixes
This commit fixes #41432.
Differential Revision: D23339854