Fix docs for kwargs, q-z #43589
Fix docs for kwargs, q-z #43589
Conversation
💊 CI failures summary and remediationsAs of commit 3d542ff (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 31 times. |
mruberry
added
triaged
|
@mruberry This should be ready |
|
Want to rebase this? Last update was in August. |
|
@mruberry I rebased this 4 hours ago |
Oh, cool. It's not showing properly for some reason. |
| add_docstr(torch.randint_like, | ||
| """ | ||
| randint_like(input, low=0, high, dtype=None, layout=torch.strided, device=None, requires_grad=False, \ | ||
| randint_like(input, low=0, high, \\*, dtype=None, layout=torch.strided, device=None, requires_grad=False, \ |
There was a problem hiding this comment.
What's up with the "\*" here?
There was a problem hiding this comment.
Some docs use \\* and some use *, I don't think they are different. I compiled and looked at the generated page, and I can not see the difference either. Here I used \\* simply because there is a similar operator also uses \\*.
There was a problem hiding this comment.
Eventually we should fix that inconsistency to avoid further confusion. This PR looks great, though.
mruberry
left a comment
mruberry
left a comment
There was a problem hiding this comment.
Great better engineering fix.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
No description provided.