Skip to content

Fix docs for kwargs, f-p #43586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zasdfgbnm wants to merge 3 commits into from
Closed

Fix docs for kwargs, f-p #43586

zasdfgbnm wants to merge 3 commits into from

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented Aug 25, 2020 •
edited
Loading

No description provided.

@zasdfgbnm zasdfgbnm requested a review from mruberry August 25, 2020 22:48
@dr-ci
Copy link

dr-ci bot commented Aug 25, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit b6bb996 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 7 times.

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Aug 25, 2020

Please hold on, flake8 is complaining the line for the signature of logspace is too long, so I have to split it into two lines. I need to double-check with sphinx to see if it supports multiline signature.

@mruberry mruberry added module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 26, 2020
@zasdfgbnm zasdfgbnm mentioned this pull request Aug 26, 2020
Closed
@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented Aug 27, 2020

@mruberry This is ready too

facebook-github-bot
facebook-github-bot reviewed Aug 27, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Aug 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@zasdfgbnm zasdfgbnm deleted the docsf branch August 30, 2020 17:40
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 30, 2020

@mruberry merged this pull request in 5021ec8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

Merged module: docs Related to our documentation, both in docs/ and docblocks open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zasdfgbnm @facebook-github-bot @mruberry @pytorchbot