Remove unnecessary copies in ProcessGroupGloo for multiple inputs allreduce #43543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reduce Closes #14691. This is not needed in the multiple outputs case, because gloo allreduce broadcasts the result tensor to all the outputs. See pytorch/gloo#152 and commit pytorch/gloo@9cabb5a for more details. Came across this when debugging #42577. This effectively reverts #14688 while keeping the tests. Tested by ensuring `test_allreduce_basics` in `test_c10d.py` still works as expected. Differential Revision: [D23173945](https://our.internmc.facebook.com/intern/diff/D23173945/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D23173945/)! [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
pietern and
zhaojuanmao
as code owners
rohan-varma
added a commit
that referenced
this pull request
Aug 25, 2020
…reduce Closes #14691. This is not needed in the multiple outputs case, because gloo allreduce broadcasts the result tensor to all the outputs. See pytorch/gloo#152 and commit pytorch/gloo@9cabb5a for more details. Came across this when debugging #42577. This effectively reverts #14688 while keeping the tests. Tested by ensuring `test_allreduce_basics` in `test_c10d.py` still works as expected. Differential Revision: [D23173945](https://our.internmc.facebook.com/intern/diff/D23173945/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D23173945/)! ghstack-source-id: 110636498 Pull Request resolved: #43543
💊 CI failures summary and remediationsAs of commit babd12e (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
Contributor
Author
|
|
Contributor
|
This pull request has been merged in 5ca6cbb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Closes #14691. This is not needed in the multiple outputs case, because gloo allreduce
broadcasts the result tensor to all the outputs. See
pytorch/gloo#152 and commit
pytorch/gloo@9cabb5a
for more details. Came across this when debugging #42577.
This effectively reverts #14688 while keeping the tests.
Tested by ensuring
test_allreduce_basicsintest_c10d.pystill works as expected.Differential Revision: D23173945
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!