Fix hipify script for pytorch extensions #43528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 1f05579 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
Collaborator
|
@jeffdaily please let me know if it looks good to you and I'll land |
ngimel
added
the
triaged
Collaborator
Author
|
@ashishfarmer Can you please review the changes in this PR? |
Collaborator
Author
|
cc @lcskrishna |
|
The changes look good. I am going to run a test with torchvision to see how this change impacts hipification there, and will comment back here |
|
Torchvision builds well with the changes here. |
Collaborator
|
Is it ready for merge? |
Collaborator
|
Yes, thank you. |
ngimel
approved these changes
Aug 25, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch extensions can have .cpp or .h files which contain CUDA code that needs to be hipified. The current hipify script logic has overly strict conditions to determine which files get considered for hipification: https://github.com/pytorch/pytorch/blob/master/torch/utils/hipify/hipify_python.py#L146
These conditions might apply well to pytorch/caffe2 source code, but are overconstrained for third-party extensions.
is_pytorch_fileconditions: https://github.com/pytorch/pytorch/blob/master/torch/utils/hipify/hipify_python.py#L549is_caffe2_gpu_fileconditions: https://github.com/pytorch/pytorch/blob/master/torch/utils/hipify/hipify_python.py#L561This PR relaxes these conditions if we're hipifying a pytorch extension (specified by
is_pytorch_extension=True) and considers all the file extensions specified using theextensionsparameter: https://github.com/pytorch/pytorch/blob/master/torch/utils/hipify/hipify_python.py#L820