Properly check that reduction strings are valid for l1_loss, smoothl1_loss, and mse_loss. #43527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_loss, and mse_loss.
gchanan
changed the title
Contributor
Author
|
TODO: testing |
💊 CI failures summary and remediationsAs of commit 24b31ac (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 10 times. |
…l1_loss, smoothl1_loss, and mse_loss." Differential Revision: [D23306786](https://our.internmc.facebook.com/intern/diff/D23306786)
…l1_loss, smoothl1_loss, and mse_loss." Differential Revision: [D23306786](https://our.internmc.facebook.com/intern/diff/D23306786) [ghstack-poisoned]
gchanan
changed the title
Codecov Report
@@ Coverage Diff @@
## gh/gchanan/302/base #43527 +/- ##
=======================================================
+ Coverage 69.33% 69.34% +0.01%
=======================================================
Files 378 378
Lines 46741 46744 +3
=======================================================
+ Hits 32406 32414 +8
+ Misses 14335 14330 -5
Continue to review full report at Codecov.
|
albanD
reviewed
Aug 28, 2020
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
LGTM
F.ctc_loss() is not tested here, is that on purpose?
This was referenced Aug 28, 2020
…s, smoothl1_loss, and mse_loss." Differential Revision: [D23306786](https://our.internmc.facebook.com/intern/diff/D23306786)
Contributor
Author
|
good point, I'll add |
albanD
approved these changes
Aug 31, 2020
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D23306786