Skip to content

Conversation

@taivu1998
Copy link
Contributor

@taivu1998 taivu1998 commented Aug 24, 2020

Stack from ghstack:

Differential Revision: D23299972

taivu1998 pushed a commit that referenced this pull request Aug 24, 2020
ghstack-source-id: 55ef26e
Pull Request resolved: #43509
@taivu1998 taivu1998 requested a review from kimishpatel August 24, 2020 19:03
Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run the test and report the results here?

@taivu1998
Copy link
Contributor Author

taivu1998 commented Aug 25, 2020

Hyperparameters Time (us)
Batch_size: 1, Channels per group: 16, Height: 16, Width: 16, Groups: 1 3.990
Batch_size: 2, Channels per group: 16, Height: 16, Width: 16, Groups: 2 10.510
Batch_size: 2, Channels per group: 32, Height: 32, Width: 32, Groups: 2 47.635
Batch_size: 4, Channels per group: 32, Height: 32, Width: 32, Groups: 4 735.698
Batch_size: 4, Channels per group: 64, Height: 64, Width: 64, Groups: 4 9783.544

Copy link
Contributor

@kimishpatel kimishpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dr-ci
Copy link

dr-ci bot commented Aug 27, 2020

💊 CI failures summary and remediations

As of commit bbb0106 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 22 times.

@mingzhe09088
Copy link
Contributor

Could you add this benchmark to https://github.com/pytorch/pytorch/blob/master/benchmarks/operator_benchmark/benchmark_all_other_test.py so it will be tested automatically?

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #43509 into gh/taivu1998/5/base will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           gh/taivu1998/5/base   #43509      +/-   ##
=======================================================
- Coverage                69.32%   69.32%   -0.01%     
=======================================================
  Files                      379      379              
  Lines                    47116    47116              
=======================================================
- Hits                     32664    32663       -1     
- Misses                   14452    14453       +1     
Impacted Files Coverage Δ
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93fbbaa...bbb0106. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

@kimishpatel merged this pull request in 8722952.

@facebook-github-bot facebook-github-bot deleted the gh/taivu1998/5/head branch September 6, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants