[ONNX] Export new_empty and new_zeros #43506
Conversation
💊 CI failures summary and remediationsAs of commit de5cd88 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 71 times. |
ngimel
added
the
triaged
|
|
||
| @skipIfUnsupportedMinOpsetVersion(9) | ||
| def test_new_zero(self): | ||
| def test_new_zeros(self): |
There was a problem hiding this comment.
this test is modified in my update slice PR, isn't it better to write another test?
There was a problem hiding this comment.
I'm trying to test the dtype argument in the symbolic. I can rebase the PR and update it once your PR is merged.
|
looks good. |
Codecov Report
@@ Coverage Diff @@
## master #43506 +/- ##
==========================================
- Coverage 67.97% 67.96% -0.02%
==========================================
Files 384 384
Lines 49589 49598 +9
==========================================
Hits 33710 33710
- Misses 15879 15888 +9
Continue to review full report at Codecov.
|
… neraoof/newEmpty
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Adding symbolic to export new_empty and new_zeros Pull Request resolved: #43506 Reviewed By: houseroad Differential Revision: D23674574 Pulled By: bzinodev fbshipit-source-id: ecfcdbd4845fd3a3c6618a060129fbeee4df5dd7
9 participants
Adding symbolic to export new_empty and new_zeros