[fix] type promotion atan2 #43466

kshitij12345 · 2020-08-23T06:45:52Z

kshitij12345 · 2020-08-23T08:37:31Z

@nairbv Please review:)

Also not sure where the test should be?

test_type_promotion (which I think tests the general type promotion logic and not each operator)
Or
Test against numpy which verifies output value as well as dtype in test_torch.py (using compare_with_numpy)?

nairbv · 2020-08-24T18:30:01Z

Also not sure where the test should be?

test_type_promotion (which I think tests the general type promotion logic and not each operator)
Or
Test against numpy which verifies output value as well as dtype in test_torch.py (using compare_with_numpy)?

I'd go with test_type_promotion. There are tests in there already for unary versions of trigonometric ops, and we'd specifically be testing for the promotion behavior. In some cases our promotion behavior might also differ from numpy.

kshitij12345 · 2020-08-25T05:06:55Z

Sure. Will add test there. Thanks.

kshitij12345 · 2020-08-27T04:35:32Z

@nairbv Please review :)

kshitij12345 · 2020-08-31T05:17:45Z

Gentle Ping :)

kshitij12345 · 2020-09-02T06:20:25Z

@nairbv Gentle Ping :)

kshitij12345 · 2020-09-04T03:13:45Z

Gentle Ping :)

kshitij12345 · 2020-09-09T14:51:32Z

Gentle Ping :)

mruberry · 2020-09-17T16:36:22Z

aten/src/ATen/native/BinaryOps.cpp

-  Tensor result = at::empty({0}, self.options());
-  return native::atan2_out(result, self, other);
+  Tensor result;
+  auto iter = TensorIterator::binary_op(result, self, other);


This is cool and completely correct. Would you mind updating it, though? We now have TensorIterator::binary_float_op, which applies to atan2. That makes it so integer inputs to atan2 are always promoted to float values (just like div).

Would you make atan2 a binary_float_op and test that integer inputs are accepted and return the expected float values? This would require expanding your test in test_type_promotion and the list of types we test atan2 to with here:

pytorch/test/test_torch.py

Line 19881 in d2b4534

('atan2', '', _medium_2d, lambda t, d: [_medium_2d(t, d)], 1e-2, 1e-5, 1e-5, _float_types),

Sure. Thanks!

mruberry · 2020-09-17T19:06:53Z

test/test_type_promotion.py

        # https://github.com/pytorch/pytorch/issues/28502
        a = torch.tensor([[True, True], [False, True]], device=device)
        self.assertEqual(a.t() == 0, a.t() == False)  # noqa: E712



You can use the @dtypes decorator with pairs of dtypes if you like. For example:

@dtypes(*product(torch.testing.get_all_dtypes(), torch.testing.get_all_dtypes()) def test_atan2_type_promotion(self, device, dtypes): dtype1, dtype2 = dtypes ...

Nice! Will use that thanks!

Actually it will be hard to use as include_half is chosen based on device type.

You can use

@dtypesIfCUDA(...) @dtypes(...)

CUDA will get the dtypes in the first decorator, all other device types will get the dtypes in the second decorator. If you want CPU-specific dtypes there's also @dtypesIfCPU.

codecov · 2020-09-17T19:59:08Z

Codecov Report

Merging #43466 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #43466   +/-   ##
=======================================
  Coverage   67.83%   67.83%           
=======================================
  Files         384      384           
  Lines       49962    49962           
=======================================
+ Hits        33892    33893    +1     
+ Misses      16070    16069    -1

Impacted Files	Coverage Δ
torch/testing/_internal/expecttest.py	`78.57% <0.00%> (+1.02%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5045e...a558f43. Read the comment docs.

dr-ci · 2020-09-17T20:11:18Z

💊 CI failures summary and remediations

As of commit a558f43 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

Failed: pr/caffe2-pytorch-linux-bionic-rocm3.7-py3.6-test

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 21 times.

kshitij12345 · 2020-09-18T14:21:35Z

The updated tests fail with

======================================================================
ERROR [0.004s]: test_atan2_inplace_cpu_int16 (__main__.TestTensorDeviceOpsCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Short

======================================================================
ERROR [0.004s]: test_atan2_inplace_cpu_int32 (__main__.TestTensorDeviceOpsCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Int

======================================================================
ERROR [0.004s]: test_atan2_inplace_cpu_int64 (__main__.TestTensorDeviceOpsCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Long

======================================================================
ERROR [0.004s]: test_atan2_inplace_cpu_int8 (__main__.TestTensorDeviceOpsCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Char

======================================================================
ERROR [0.003s]: test_atan2_inplace_cpu_uint8 (__main__.TestTensorDeviceOpsCPU)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Byte

======================================================================
ERROR [0.004s]: test_atan2_inplace_cuda_int16 (__main__.TestTensorDeviceOpsCUDA)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Short

======================================================================
ERROR [0.004s]: test_atan2_inplace_cuda_int32 (__main__.TestTensorDeviceOpsCUDA)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Int

======================================================================
ERROR [0.004s]: test_atan2_inplace_cuda_int64 (__main__.TestTensorDeviceOpsCUDA)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Long

======================================================================
ERROR [0.004s]: test_atan2_inplace_cuda_int8 (__main__.TestTensorDeviceOpsCUDA)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Char

======================================================================
ERROR [0.003s]: test_atan2_inplace_cuda_uint8 (__main__.TestTensorDeviceOpsCUDA)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_device_type.py", line 270, in instantiated_test
    result = test_fn(self, *args)
  File "test_torch.py", line 20173, in fn
    cpu_result = getattr(cpu_tensor, op_str)(*cpu_args)
RuntimeError: result type Float can't be cast to the desired output type Byte

Which makes sense. Updating the generated test code for this.

Note that div is not tested for behavior with integer types currently. Will update that as well.

…oat_ops

kshitij12345 · 2020-09-18T14:39:31Z

test/test_type_promotion.py

+        def is_float(dtype):
+            return dtype in torch.testing.get_all_fp_dtypes(include_half=include_half, include_bfloat16=False)
+
+        def get_binary_float_result_type(x, y):


Is there any function (like torch.result_type) which actually does this for binary_float_op promotion behavior?

Unfortunately no. Which makes torch.result_type kind of misleading.

kshitij12345 · 2020-09-18T18:03:04Z

@mruberry

PR might need an update from XLA side as well, I guess.
https://app.circleci.com/jobs/github/pytorch/pytorch/7578739

======================================================================
Sep 18 16:08:01 ERROR [0.043s]: test_atan2_xla_int16 (__main__.TestTensorDeviceOpsXLA)
Sep 18 16:08:01 ----------------------------------------------------------------------
Sep 18 16:08:01 Traceback (most recent call last):
Sep 18 16:08:01   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 270, in instantiated_test
Sep 18 16:08:01     result = test_fn(self, *args)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/../../test/test_torch.py", line 20200, in fn
Sep 18 16:08:01     self.assertEqual(cpu_result, device_result, atol=precision, rtol=0, exact_dtype=False)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 542, in assertEqual
Sep 18 16:08:01     x, y = self.prepare_for_compare(x, y)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 489, in prepare_for_compare
Sep 18 16:08:01     y = ty.to(device='cpu')
Sep 18 16:08:01 RuntimeError: Unimplemented: From /job:localservice/replica:0/task:0:
Sep 18 16:08:01 2 root error(s) found.
Sep 18 16:08:01   (0) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01   (1) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01 	 [[XRTCompile_G3]]
Sep 18 16:08:01 0 successful operations.
Sep 18 16:08:01 0 derived errors ignored.
Sep 18 16:08:01 
Sep 18 16:08:01 ======================================================================
Sep 18 16:08:01 ERROR [0.034s]: test_atan2_xla_int32 (__main__.TestTensorDeviceOpsXLA)
Sep 18 16:08:01 ----------------------------------------------------------------------
Sep 18 16:08:01 Traceback (most recent call last):
Sep 18 16:08:01   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 270, in instantiated_test
Sep 18 16:08:01     result = test_fn(self, *args)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/../../test/test_torch.py", line 20200, in fn
Sep 18 16:08:01     self.assertEqual(cpu_result, device_result, atol=precision, rtol=0, exact_dtype=False)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 542, in assertEqual
Sep 18 16:08:01     x, y = self.prepare_for_compare(x, y)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 489, in prepare_for_compare
Sep 18 16:08:01     y = ty.to(device='cpu')
Sep 18 16:08:01 RuntimeError: Unimplemented: From /job:localservice/replica:0/task:0:
Sep 18 16:08:01 2 root error(s) found.
Sep 18 16:08:01   (0) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01   (1) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01 	 [[XRTCompile_G3]]
Sep 18 16:08:01 0 successful operations.
Sep 18 16:08:01 0 derived errors ignored.
Sep 18 16:08:01 
Sep 18 16:08:01 ======================================================================
Sep 18 16:08:01 ERROR [0.035s]: test_atan2_xla_int64 (__main__.TestTensorDeviceOpsXLA)
Sep 18 16:08:01 ----------------------------------------------------------------------
Sep 18 16:08:01 Traceback (most recent call last):
Sep 18 16:08:01   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 270, in instantiated_test
Sep 18 16:08:01     result = test_fn(self, *args)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/../../test/test_torch.py", line 20200, in fn
Sep 18 16:08:01     self.assertEqual(cpu_result, device_result, atol=precision, rtol=0, exact_dtype=False)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 542, in assertEqual
Sep 18 16:08:01     x, y = self.prepare_for_compare(x, y)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 489, in prepare_for_compare
Sep 18 16:08:01     y = ty.to(device='cpu')
Sep 18 16:08:01 RuntimeError: Unimplemented: From /job:localservice/replica:0/task:0:
Sep 18 16:08:01 2 root error(s) found.
Sep 18 16:08:01   (0) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01   (1) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01 	 [[XRTCompile_G3]]
Sep 18 16:08:01 0 successful operations.
Sep 18 16:08:01 0 derived errors ignored.
Sep 18 16:08:01 
Sep 18 16:08:01 ======================================================================
Sep 18 16:08:01 ERROR [0.035s]: test_atan2_xla_int8 (__main__.TestTensorDeviceOpsXLA)
Sep 18 16:08:01 ----------------------------------------------------------------------
Sep 18 16:08:01 Traceback (most recent call last):
Sep 18 16:08:01   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 270, in instantiated_test
Sep 18 16:08:01     result = test_fn(self, *args)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/../../test/test_torch.py", line 20200, in fn
Sep 18 16:08:01     self.assertEqual(cpu_result, device_result, atol=precision, rtol=0, exact_dtype=False)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 542, in assertEqual
Sep 18 16:08:01     x, y = self.prepare_for_compare(x, y)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 489, in prepare_for_compare
Sep 18 16:08:01     y = ty.to(device='cpu')
Sep 18 16:08:01 RuntimeError: Unimplemented: From /job:localservice/replica:0/task:0:
Sep 18 16:08:01 2 root error(s) found.
Sep 18 16:08:01   (0) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01   (1) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01 	 [[XRTCompile_G20]]
Sep 18 16:08:01 0 successful operations.
Sep 18 16:08:01 0 derived errors ignored.
Sep 18 16:08:01 
Sep 18 16:08:01 ======================================================================
Sep 18 16:08:01 ERROR [0.034s]: test_atan2_xla_uint8 (__main__.TestTensorDeviceOpsXLA)
Sep 18 16:08:01 ----------------------------------------------------------------------
Sep 18 16:08:01 Traceback (most recent call last):
Sep 18 16:08:01   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 270, in instantiated_test
Sep 18 16:08:01     result = test_fn(self, *args)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/../../test/test_torch.py", line 20200, in fn
Sep 18 16:08:01     self.assertEqual(cpu_result, device_result, atol=precision, rtol=0, exact_dtype=False)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 542, in assertEqual
Sep 18 16:08:01     x, y = self.prepare_for_compare(x, y)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/pytorch_test_base.py", line 489, in prepare_for_compare
Sep 18 16:08:01     y = ty.to(device='cpu')
Sep 18 16:08:01 RuntimeError: Unimplemented: From /job:localservice/replica:0/task:0:
Sep 18 16:08:01 2 root error(s) found.
Sep 18 16:08:01   (0) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01   (1) Unimplemented: binary integer op 'atan2'
Sep 18 16:08:01 	 [[{{node XRTCompile}}]]
Sep 18 16:08:01 	 [[XRTCompile_G20]]
Sep 18 16:08:01 0 successful operations.
Sep 18 16:08:01 0 derived errors ignored.
Sep 18 16:08:01 
Sep 18 16:08:01 ======================================================================
Sep 18 16:08:01 FAIL [0.019s]: test_atan2_inplace_xla_int16 (__main__.TestTensorDeviceOpsXLA)
Sep 18 16:08:01 ----------------------------------------------------------------------
Sep 18 16:08:01 Traceback (most recent call last):
Sep 18 16:08:01   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 270, in instantiated_test
Sep 18 16:08:01     result = test_fn(self, *args)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/../../test/test_torch.py", line 20185, in fn
Sep 18 16:08:01     device_result = getattr(device_tensor, op_str)(*device_args)
Sep 18 16:08:01 AssertionError: RuntimeError not raised
Sep 18 16:08:01 
Sep 18 16:08:01 ======================================================================
Sep 18 16:08:01 FAIL [0.019s]: test_atan2_inplace_xla_int32 (__main__.TestTensorDeviceOpsXLA)
Sep 18 16:08:01 ----------------------------------------------------------------------
Sep 18 16:08:01 Traceback (most recent call last):
Sep 18 16:08:01   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 270, in instantiated_test
Sep 18 16:08:01     result = test_fn(self, *args)
Sep 18 16:08:01   File "/var/lib/jenkins/workspace/xla/test/../../test/test_torch.py", line 20185, in fn
Sep 18 16:08:01     device_result = getattr(device_tensor, op_str)(*device_args)
Sep 18 16:08:01 AssertionError: RuntimeError not raised
Sep 18 16:08:01

JackCaoG · 2020-09-18T18:12:30Z

I will take a look at the XLA failure. @kshitij12345 Could you open an issue under pytorch/xla to track this?

mruberry · 2020-09-18T20:48:50Z

I will take a look at the XLA failure. @kshitij12345 Could you open an issue under pytorch/xla to track this?

We can also skip the XLA tests for now: @onlyOnCPUAndCUDA.

JackCaoG · 2020-09-18T21:04:35Z

I will take a look at the XLA failure. @kshitij12345 Could you open an issue under pytorch/xla to track this?

We can also skip the XLA tests for now: @onlyOnCPUAndCUDA.

It is fine, I made the change on xla side and verified that test passed with the fix.

kshitij12345 · 2020-09-19T06:33:24Z

@JackCaoG Thanks for the fix. However it looks like the XLA failures still exist.

JackCaoG · 2020-09-19T08:17:06Z

I just merged the fix, you should see the test passing now

kshitij12345 · 2020-09-19T08:23:08Z

Great thanks!

kshitij12345 · 2020-09-21T04:44:28Z

@mruberry Gentle Ping:)

mruberry

Nice work as usual, @kshitij12345!

facebook-github-bot

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-09-24T06:19:28Z

@mruberry merged this pull request in 0b6b735.

fix: type promotion atan2

28d8fe4

pytorchbot added the open source label Aug 23, 2020

ngimel requested a review from nairbv August 25, 2020 03:52

ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 25, 2020

add test for atan2 type promotion

3c28c3f

mruberry self-requested a review September 17, 2020 16:30

mruberry reviewed Sep 17, 2020

View reviewed changes

kshitij12345 added 3 commits September 17, 2020 22:12

Merge branch 'master' into fix/type-promo/atan2

4eef85b

use binary_float_op

e38ec84

update dtypes for testing

f1e2e68

mruberry reviewed Sep 17, 2020

View reviewed changes

kshitij12345 added 2 commits September 18, 2020 19:51

update test_torch gen tests to verify inplace ops throw for binary_fl…

e6b9ffa

…oat_ops

update test_type_promotion for new promotion rules

2ea6130

kshitij12345 commented Sep 18, 2020

View reviewed changes

kshitij12345 mentioned this pull request Sep 18, 2020

[pt_break] atan2 : promote integer to float support pytorch/xla#2499

Closed

JackCaoG mentioned this pull request Sep 18, 2020

Handle int types for atan2 pytorch/xla#2500

Merged

kshitij12345 added 3 commits September 19, 2020 08:49

use dtypes and dtypesIfCUDA

495662e

Merge branch 'master' into fix/type-promo/atan2

36c4da9

fix stray merge

e36cdb2

Merge branch 'master' into fix/type-promo/atan2

a558f43

mruberry self-requested a review September 22, 2020 04:21

mruberry approved these changes Sep 22, 2020

View reviewed changes

facebook-github-bot reviewed Sep 22, 2020

View reviewed changes

facebook-github-bot closed this in 0b6b735 Sep 24, 2020

facebook-github-bot added the merged label Sep 24, 2020

mruberry added the Merged label Oct 28, 2020

[fix] type promotion atan2 #43466

[fix] type promotion atan2 #43466

Uh oh!

Conversation

kshitij12345 commented Aug 23, 2020

Uh oh!

kshitij12345 commented Aug 23, 2020

Uh oh!

nairbv commented Aug 24, 2020

Uh oh!

kshitij12345 commented Aug 25, 2020

Uh oh!

kshitij12345 commented Aug 27, 2020

Uh oh!

kshitij12345 commented Aug 31, 2020

Uh oh!

kshitij12345 commented Sep 2, 2020

Uh oh!

kshitij12345 commented Sep 4, 2020

Uh oh!

kshitij12345 commented Sep 9, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dr-ci bot commented Sep 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

ci.pytorch.org: 1 failed

Uh oh!

kshitij12345 commented Sep 18, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kshitij12345 commented Sep 18, 2020

Uh oh!

JackCaoG commented Sep 18, 2020

Uh oh!

mruberry commented Sep 18, 2020

Uh oh!

JackCaoG commented Sep 18, 2020

Uh oh!

kshitij12345 commented Sep 19, 2020

Uh oh!

JackCaoG commented Sep 19, 2020

Uh oh!

kshitij12345 commented Sep 19, 2020

Uh oh!

kshitij12345 commented Sep 21, 2020

Uh oh!

mruberry left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Sep 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

codecov bot commented Sep 17, 2020 •

edited

Loading

dr-ci bot commented Sep 17, 2020 •

edited

Loading