Implement JIT Enum type serialization and deserialization #43460
Conversation
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 7faf3e3 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 11 times. |
gmagogsfm
changed the title
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@gmagogsfm has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
torch/csrc/jit/python/python_ir.cpp
Outdated
There was a problem hiding this comment.
Out of curiosity, what was the change?
There was a problem hiding this comment.
Line 797, replaced EnumNameValue with its underlying type std::pair<std::string, IValue>. Unsure why EnumNameValue isn't exposed correctly on windows.
There was a problem hiding this comment.
Thanks for approval, could you help stamp the phabricator diff as well? Thanks!
Enhance enum type to include all contained enum names and values Adds code parsing for enum type in deserialization Enabled serialization/deserialization test in most TestCases. (With a few dangling issues to be addressed in later PRs to avoid this PR grows too large)
|
@gmagogsfm merged this pull request in 35a36c1. |
4 participants
[Re-review tips: nothing changed other than a type in python_ir.cpp to fix a windows build failure]
Adds code printing for enum type
Enhance enum type to include all contained enum names and values
Adds code parsing for enum type in deserialization
Enabled serialization/deserialization test in most TestCases. (With a few dangling issues to be addressed in later PRs to avoid this PR grows too large)