[ONNX] Update in scatter ONNX export when scalar src has different type #43440
Conversation
💊 CI failures summary and remediationsAs of commit 8c5712b (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 9 times. |
|
@bzinodev - None of these failures seem related to the this (minor) change. I will try rerunning the jobs. |
spandantiwari
force-pushed
the
spandantiwari/fix_onnx_scatter_type
branch
from
ddc9bed to
8c5712b
Compare
|
Same failures after re-running the failing jobs. Seems unrelated. |
ngimel
added
the
triaged
neginraoof
left a comment
neginraoof
left a comment
There was a problem hiding this comment.
Thanks, looks good to me.
|
@bzinodev - All the failures are resolved after (another) rebase and rerun. The CI is green. I believe this is ready for your review and merge. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I am not able to see the internal failing test. |
|
@houseroad merged this pull request in 1a21c92. |
7 participants
torch.scatterallowssrcto be of different type whensrcis a scalar. This requires a an explicit cast op to be inserted in the ONNX graph because ONNXScatterElementsdoes not allow different types. This PR updates the export oftorch.scatterwith this logic.