Skip to content

[ONNX] Update repeat op #43430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shubhambhokare1 wants to merge 28 commits into from
Closed

[ONNX] Update repeat op #43430

shubhambhokare1 wants to merge 28 commits into from

Conversation

@shubhambhokare1
Copy link
Collaborator

@shubhambhokare1 shubhambhokare1 commented Aug 21, 2020 •
edited
Loading

Update repeat op so that the inputs to sizes argument can a mixture of dynamic and constant inputs

@dr-ci
Copy link

dr-ci bot commented Aug 21, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3f45948 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

codecov.io: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 58 times.

@ngimel ngimel requested a review from houseroad August 25, 2020 04:12
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 25, 2020
BowenBao
BowenBao reviewed Aug 27, 2020
View reviewed changes
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update name/description "reshape" -> "repeat"?

neginraoof
neginraoof approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@neginraoof neginraoof left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!
Please update the description.

@shubhambhokare1 shubhambhokare1 changed the title [ONNX] Update reshape op [ONNX] Update repeat op Aug 27, 2020
BowenBao
BowenBao reviewed Aug 27, 2020
View reviewed changes
@neginraoof
Copy link
Contributor

neginraoof commented Sep 1, 2020

@shubhambhokare1 Please fix the test failure. You might want to disable test_repeat for opset 8.

@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #43430 into master will decrease coverage by 0.00%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43430      +/-   ##
==========================================
- Coverage   69.29%   69.28%   -0.01%     
==========================================
  Files         379      379              
  Lines       47074    47082       +8     
==========================================
+ Hits        32622    32623       +1     
- Misses      14452    14459       +7
Impacted Files Coverage Δ
torch/onnx/symbolic_opset8.py 29.06% <7.69%> (-1.75%) ⬇️
torch/onnx/symbolic_opset9.py 35.67% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c277f...3f45948. Read the comment docs.

BowenBao
BowenBao approved these changes Sep 2, 2020
View reviewed changes
Copy link
Collaborator

@BowenBao BowenBao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

facebook-github-bot
facebook-github-bot reviewed Sep 3, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 5, 2020

@bzinodev merged this pull request in f3bf6a4.

@garymm garymm mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@BowenBao BowenBao BowenBao approved these changes

@houseroad houseroad Awaiting requested review from houseroad

+1 more reviewer

@neginraoof neginraoof neginraoof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@shubhambhokare1 @neginraoof @facebook-github-bot @BowenBao @ngimel @pytorchbot @mruberry