Skip to content

Add alias torch.negative to torch.neg. #43400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hameerabbasi wants to merge 1 commit into from
Closed

Add alias torch.negative to torch.neg. #43400

hameerabbasi wants to merge 1 commit into from

Conversation

@hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented Aug 21, 2020

xref #42515

@hameerabbasi hameerabbasi requested a review from apaszke as a code owner August 21, 2020 08:33
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 21, 2020
@dr-ci
Copy link

dr-ci bot commented Aug 21, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d7f19c2 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

1 failure confirmed as flaky and can be ignored:

  • pytorch_bazel_test
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@hameerabbasi hameerabbasi mentioned this pull request Aug 21, 2020
Closed
8 tasks
@hameerabbasi hameerabbasi requested review from mruberry and removed request for apaszke August 21, 2020 14:18
@hameerabbasi
Copy link
Collaborator Author

hameerabbasi commented Aug 21, 2020

This should be fairly painless. :) I've just copied the template from last time. The remaining 2 CI jobs have stalled, both their build phases have succeeded but the test phases are taking a while to start for some reason.

@mruberry
Copy link
Collaborator

mruberry commented Aug 21, 2020

This should be fairly painless. :) I've just copied the template from last time. The remaining 2 CI jobs have stalled, both their build phases have succeeded but the test phases are taking a while to start for some reason.

Sorry about the ROCm build signal. We're investigating an issue with them.

mruberry
mruberry approved these changes Aug 21, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

facebook-github-bot
facebook-github-bot reviewed Aug 21, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 24, 2020

@mruberry merged this pull request in c4e8416.

@hameerabbasi hameerabbasi deleted the alias-negative branch August 24, 2020 12:08
@mruberry mruberry mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hameerabbasi @mruberry @facebook-github-bot @pytorchbot