Improving ModuleList indexing error msg #43361
Conversation
💊 CI failures summary and remediationsAs of commit f526bdb (more details on the Dr. CI page):
Extra GitHub checks: 2 failed
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 6 times. |
facebook-github-bot
added
the
oncall: jit
| from jit.test_unsupported_ops import TestUnsupportedOps # noqa: F401 | ||
| from jit.test_freezing import TestFreezing # noqa: F401 | ||
| from jit.test_save_load import TestSaveLoad # noqa: F401 | ||
| from jit.test_module_containers import TestModuleContainers # noqa: F401 |
There was a problem hiding this comment.
uh oh did I cause this test file to not even run in CI by not remembering to include it here?
wconstab
left a comment
wconstab
left a comment
There was a problem hiding this comment.
LGTM. Thanks for cleaning up.
…ove_integer_literal_error
Codecov Report
@@ Coverage Diff @@
## master #43361 +/- ##
=======================================
Coverage 69.26% 69.26%
=======================================
Files 381 381
Lines 47580 47580
=======================================
Hits 32954 32954
Misses 14626 14626
Continue to review full report at Codecov.
|
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
4 participants
Follow up to #41946, to suggest enumerating a module as an alternative if a user tries indexing into a modulelist/sequential with a non-integer literal