Skip to content

Add alias torch.fix for torch.trunc to be compatible with NumPy. #43326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hameerabbasi wants to merge 1 commit into from
Closed

Add alias torch.fix for torch.trunc to be compatible with NumPy. #43326

hameerabbasi wants to merge 1 commit into from

Conversation

@hameerabbasi
Copy link
Collaborator

@hameerabbasi hameerabbasi commented Aug 20, 2020

xref #42515

@hameerabbasi hameerabbasi requested a review from apaszke as a code owner August 20, 2020 09:28
@hameerabbasi hameerabbasi requested a review from mruberry August 20, 2020 09:28
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 20, 2020
@hameerabbasi hameerabbasi mentioned this pull request Aug 20, 2020
Closed
8 tasks
hameerabbasi
hameerabbasi commented Aug 20, 2020
View reviewed changes
@hameerabbasi hameerabbasi changed the title Add alias for to be compatible with NumPy. Add alias torch.fix for torch.trunc to be compatible with NumPy. Aug 20, 2020
@dr-ci
Copy link

dr-ci bot commented Aug 20, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit dac7d37 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 10 times.

mruberry
mruberry reviewed Aug 20, 2020
View reviewed changes
mruberry
mruberry reviewed Aug 20, 2020
View reviewed changes
mruberry
mruberry reviewed Aug 20, 2020
View reviewed changes
mruberry
mruberry reviewed Aug 20, 2020
View reviewed changes
mruberry
mruberry reviewed Aug 20, 2020
View reviewed changes
@mruberry mruberry removed the request for review from apaszke August 20, 2020 10:47
@hameerabbasi
Copy link
Collaborator Author

hameerabbasi commented Aug 20, 2020 •
edited
Loading

I think this one is ready to merge. The remaining CI job has stalled for quite a while and isn't moving. I've also addressed all the comments.

@hameerabbasi hameerabbasi requested a review from mruberry August 20, 2020 16:18
mruberry
mruberry approved these changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @hameerabbasi!

facebook-github-bot
facebook-github-bot reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 21, 2020

@mruberry merged this pull request in e31cd46.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@mruberry mruberry mruberry approved these changes

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hameerabbasi @facebook-github-bot @mruberry @pytorchbot