[quant] Add benchmarks for quantized embeddingbag module #43296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Use common config for float and quantized embedding_bag modules Test Plan: ``` python -m pt.qembeddingbag_test Benchmarking PyTorch: qEmbeddingBag Mode: Eager Name: qEmbeddingBag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetTrue_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: True, device: cpu Forward Execution Time (us) : 35.738 Benchmarking PyTorch: qEmbeddingBag Mode: Eager Name: qEmbeddingBag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetFalse_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: False, device: cpu Forward Execution Time (us) : 62.708 python -m pt.embeddingbag_test Benchmarking PyTorch: embeddingbag Mode: Eager Name: embeddingbag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetTrue_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: True, device: cpu Forward Execution Time (us) : 46.878 Benchmarking PyTorch: embeddingbag Mode: Eager Name: embeddingbag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetFalse_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: False, device: cpu Forward Execution Time (us) : 103.904 ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Aug 19, 2020
supriyar
added a commit
that referenced
this pull request
Aug 19, 2020
Summary: Use common config for float and quantized embedding_bag modules Test Plan: ``` python -m pt.qembeddingbag_test Benchmarking PyTorch: qEmbeddingBag Mode: Eager Name: qEmbeddingBag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetTrue_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: True, device: cpu Forward Execution Time (us) : 35.738 Benchmarking PyTorch: qEmbeddingBag Mode: Eager Name: qEmbeddingBag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetFalse_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: False, device: cpu Forward Execution Time (us) : 62.708 python -m pt.embeddingbag_test Benchmarking PyTorch: embeddingbag Mode: Eager Name: embeddingbag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetTrue_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: True, device: cpu Forward Execution Time (us) : 46.878 Benchmarking PyTorch: embeddingbag Mode: Eager Name: embeddingbag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetFalse_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: False, device: cpu Forward Execution Time (us) : 103.904 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2644726 Pull Request resolved: #43296
💊 CI failures summary and remediationsAs of commit 77a941e (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 4 times. |
vkuzo
approved these changes
Aug 20, 2020
Contributor
vkuzo
left a comment
vkuzo
left a comment
There was a problem hiding this comment.
thanks for merging it with floating point!
| embedding_dim=dim, | ||
| mode=mode, | ||
| include_last_offset=include_last_offset).to(device=device) | ||
| numpy.random.seed((1 << 32) - 1) |
Contributor
There was a problem hiding this comment.
just curious, what's the context on this line?
Contributor
Author
There was a problem hiding this comment.
It was used in the embeddingbag_test. So I did the same here for consistency
Summary: Use common config for float and quantized embedding_bag modules Test Plan: ``` python -m pt.qembeddingbag_test Benchmarking PyTorch: qEmbeddingBag Mode: Eager Name: qEmbeddingBag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetTrue_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: True, device: cpu Forward Execution Time (us) : 35.738 Benchmarking PyTorch: qEmbeddingBag Mode: Eager Name: qEmbeddingBag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetFalse_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: False, device: cpu Forward Execution Time (us) : 62.708 python -m pt.embeddingbag_test Benchmarking PyTorch: embeddingbag Mode: Eager Name: embeddingbag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetTrue_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: True, device: cpu Forward Execution Time (us) : 46.878 Benchmarking PyTorch: embeddingbag Mode: Eager Name: embeddingbag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetFalse_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: False, device: cpu Forward Execution Time (us) : 103.904 ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Aug 20, 2020
Summary: Use common config for float and quantized embedding_bag modules Test Plan: ``` python -m pt.qembeddingbag_test Benchmarking PyTorch: qEmbeddingBag Mode: Eager Name: qEmbeddingBag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetTrue_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: True, device: cpu Forward Execution Time (us) : 35.738 Benchmarking PyTorch: qEmbeddingBag Mode: Eager Name: qEmbeddingBag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetFalse_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: False, device: cpu Forward Execution Time (us) : 62.708 python -m pt.embeddingbag_test Benchmarking PyTorch: embeddingbag Mode: Eager Name: embeddingbag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetTrue_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: True, device: cpu Forward Execution Time (us) : 46.878 Benchmarking PyTorch: embeddingbag Mode: Eager Name: embeddingbag_embeddingbags10_dim4_modesum_input_size8_offset0_sparseTrue_include_last_offsetFalse_cpu Input: embeddingbags: 10, dim: 4, mode: sum, input_size: 8, offset: 0, sparse: True, include_last_offset: False, device: cpu Forward Execution Time (us) : 103.904 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 079cf2f Pull Request resolved: #43296
Contributor
|
This pull request has been merged in 7024ce8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Use common config for float and quantized embedding_bag modules
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23245531