💊 CI failures summary and remediations

As of commit 9f405b4 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

• 1/1 broken upstream at merge base 9a1f2b3 on Aug 20 from 9:00am to 6:29pm PDT (18 commits; 397325a - 5cf8592)

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

• pytorch_linux_backward_compatibility_check_test on Aug 20 from 9:00am to 6:29pm PDT (18 commits; 397325a - 5cf8592)
  • 🔁 rerun

lg. Optional suggeston for future PRs: would it make sense to have a clean split between:

• eager mode
• fx
• shared between eager mode and fx

i.e. the shared code would be in a separate directory or file, to make it clear what's shared and what's not, with ideally the shared part of the codebase growing over time, and eager-only shrinking?

If you just talk about things under torch/quantization then there is not much that is eager mode only, probably just https://github.com/pytorch/pytorch/blob/master/torch/quantization/quantize.py and https://github.com/pytorch/pytorch/blob/master/torch/quantization/stubs.py I think. There is also https://github.com/pytorch/pytorch/blob/master/torch/nn/quantized/modules/functional_modules.py which is only used in eager mode.

we can certainly put them in the same folder, but not sure if it's worth it or not.

This pull request has been merged in 217ddea.