-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Make TensorPipe the default backend for RPC #43246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit c9a914f (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 5 times. |
Differential Revision: [D23206042](https://our.internmc.facebook.com/intern/diff/D23206042) [ghstack-poisoned]
osalpekar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
||
| The Process Group agent instantiates a process group from | ||
| the :mod:`~torch.distributed` module and utilizes its point-to-point | ||
| communication capabilities to send RPC messages across. Internally, the process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we can probably remove the word "across"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edited in the PR on top.
jiayisuse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to move RPC to tensorpipe! Let's wait for CI signals :)
|
@osalpekar merged this pull request in 5006d24. |
Stack from ghstack:
Differential Revision: D23206042