Skip to content

Conversation

@mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Aug 19, 2020

Stack from ghstack:

Differential Revision: D23206042

mrshenli added a commit that referenced this pull request Aug 19, 2020
ghstack-source-id: 90e931c
Pull Request resolved: #43246
@mrshenli mrshenli requested a review from lw August 19, 2020 01:59
@dr-ci
Copy link

dr-ci bot commented Aug 19, 2020

💊 CI failures summary and remediations

As of commit c9a914f (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

mrshenli added a commit that referenced this pull request Aug 20, 2020
ghstack-source-id: 2bb2a52
Pull Request resolved: #43246
@mrshenli mrshenli mentioned this pull request Aug 20, 2020
Copy link
Member

@osalpekar osalpekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


The Process Group agent instantiates a process group from
the :mod:`~torch.distributed` module and utilizes its point-to-point
communication capabilities to send RPC messages across. Internally, the process
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we can probably remove the word "across"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edited in the PR on top.

Copy link
Contributor

@jiayisuse jiayisuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to move RPC to tensorpipe! Let's wait for CI signals :)

@facebook-github-bot
Copy link
Contributor

@osalpekar merged this pull request in 5006d24.

@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/221/head branch August 24, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants