Skip to content

Conversation

@mitchellspryn
Copy link
Contributor

Summary:
XNNPack is already being used for the convolution2d operation. Add the
ability for it to be used with transpose convolution.

Test Plan:
Manually generate networks that contain the convolution2dT layer.
Verify that the current algorithm and the XNNPack algorithm give the same
results for a variety of inputs and parameter combinations.

Differential Revision: D23184249

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 18, 2020
@dr-ci
Copy link

dr-ci bot commented Aug 18, 2020

💊 CI failures summary and remediations

As of commit 3b17871 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 38 times.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

Summary:
Pull Request resolved: pytorch#43233

XNNPack is already being used for the convolution2d operation. Add the
ability for it to be used with transpose convolution.

Test Plan: buck run caffe2/test:xnnpack_integration

Differential Revision: D23184249

fbshipit-source-id: 4172afa331bbac7db1b4bc9ca2023f30fb9a1210
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23184249

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b630c18.

Comment on lines +82 to +84
graph(%a, %w, %b, %stride:int[], %padding:int[], %dilation:int[],
%transposed:bool, %output_padding:int[], %groups:int, %benchmark:bool,
%deterministic:bool, %cudnn_enabled:bool):
Copy link

@z-a-f z-a-f Sep 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This pattern is deprecated, and your code might fail

@z-a-f
Copy link

z-a-f commented Sep 2, 2020

nit: General convention for the transposed convolution is conv_transposeXd, where X is the spatial dimension

@z-a-f
Copy link

z-a-f commented Sep 2, 2020

@mitchellspryn #43199 fixes the pattern, please take a look in case it messes up your parts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fb-exported Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants