Skip to content

Fix codegen/cuda gcc-5.4 compilation issues #43223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

Fix codegen/cuda gcc-5.4 compilation issues #43223

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Aug 18, 2020

Most of the fixes is the same old enum-is-not-hasheable error
In manager.cpp use std::unordered_map::emplace rather than insert to avoid error triggered by missed copy elision
This regression was introduced by #43129

@malfet malfet requested review from csarofeen and ezyang August 18, 2020 21:00
@malfet malfet requested a review from apaszke as a code owner August 18, 2020 21:00
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 18, 2020
facebook-github-bot
facebook-github-bot reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@seemethere
Copy link
Member

seemethere commented Aug 18, 2020

Might also be good to run this through a ci-all branch in order to verify

albanD
albanD approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dr-ci
Copy link

dr-ci bot commented Aug 18, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit c5e3550 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

1 failure confirmed as flaky and can be ignored:

  • pytorch_windows_vs2019_py36_cpu_build

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

@jjsjann123
Copy link
Collaborator

jjsjann123 commented Aug 18, 2020 •
edited
Loading

Adding a TypeHash in every unordered_map is hard to manage for developer on later gcc > 5.4. Can we consider #43222 ? just trying to avoid similar breakage in the next PR to the codegen piece.

Not trying to promote the other PR, I wasn't aware someone is fixing this when I issued that.

@malfet malfet force-pushed the malfet/fix-cuda-fuser-compilation-again branch from e5ab414 to 169b8e0 Compare August 18, 2020 21:14
facebook-github-bot
facebook-github-bot reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@malfet
Copy link
Contributor Author

malfet commented Aug 18, 2020

Might also be good to run this through a ci-all branch in order to verify

@seemethere, I've just applied this change manually in https://app.circleci.com/pipelines/github/pytorch/pytorch/201646/workflows/9ca92568-c081-4518-8977-9692d5f73602/jobs/6784578

@malfet malfet added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 18, 2020
@malfet
Fix codegen/cuda gcc-5.4 compilation issues
c5e3550 
Most of the fixes is the same old enum-is-not-hasheable error
In manager.cpp use std::unordered_map::emplace rather than `insert` to avoid error triggered by missed copy elision
This regression was introduced by pytorch#43129
@malfet malfet force-pushed the malfet/fix-cuda-fuser-compilation-again branch from 169b8e0 to c5e3550 Compare August 18, 2020 21:33
@malfet
Copy link
Contributor Author

malfet commented Aug 18, 2020

Another update to fix linter errors

facebook-github-bot
facebook-github-bot reviewed Aug 18, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 19, 2020

@malfet merged this pull request in d06f181.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 19, 2020

@malfet merged this pull request in d06f181.

@malfet malfet deleted the malfet/fix-cuda-fuser-compilation-again branch August 19, 2020 02:19
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Oct 29, 2022
@malfet @facebook-github-bot
Fix codegen/cuda gcc-5.4 compilation issues (#43223)
714aa42 
Summary:
Most of the fixes is the same old enum-is-not-hasheable error
In manager.cpp use std::unordered_map::emplace rather than `insert` to avoid error triggered by missed copy elision
This regression was introduced by pytorch/pytorch#43129

Pull Request resolved: pytorch/pytorch#43223

Reviewed By: albanD, seemethere

Differential Revision: D23198330

Pulled By: malfet

fbshipit-source-id: 576082f7a4454dd29182892c9c4e0b51a967d456
jjsjann123 pushed a commit to jjsjann123/nvfuser that referenced this pull request Nov 10, 2022
@malfet @facebook-github-bot
Fix codegen/cuda gcc-5.4 compilation issues (#43223)
7feaa76 
Summary:
Most of the fixes is the same old enum-is-not-hasheable error
In manager.cpp use std::unordered_map::emplace rather than `insert` to avoid error triggered by missed copy elision
This regression was introduced by pytorch/pytorch#43129

Pull Request resolved: pytorch/pytorch#43223

Reviewed By: albanD, seemethere

Differential Revision: D23198330

Pulled By: malfet

fbshipit-source-id: 576082f7a4454dd29182892c9c4e0b51a967d456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@albanD albanD albanD approved these changes

@ezyang ezyang Awaiting requested review from ezyang

@csarofeen csarofeen Awaiting requested review from csarofeen

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@malfet @seemethere @jjsjann123 @facebook-github-bot @albanD @mruberry