[quant] Enable from_float for quantized Embedding_Bag #43176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Convert floating point nn.EmbeddingBag module to nn.quantized.dynamic.EmbeddingBag module Test Plan: python test/test_quantization.py TestDynamicQuantizedModule.test_embedding_bag_api python test/test_quantization.py TestPostTrainingDynamic.test_embedding_quantization Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Aug 17, 2020
supriyar
added a commit
that referenced
this pull request
Aug 17, 2020
Summary: Convert floating point nn.EmbeddingBag module to nn.quantized.dynamic.EmbeddingBag module Test Plan: python test/test_quantization.py TestDynamicQuantizedModule.test_embedding_bag_api python test/test_quantization.py TestPostTrainingDynamic.test_embedding_quantization Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c9a00f1 Pull Request resolved: #43176
💊 CI failures summary and remediationsAs of commit aede308 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 14 times. |
vkuzo
reviewed
Aug 18, 2020
vkuzo
approved these changes
Aug 18, 2020
| nn.RNNCell: nnqd.RNNCell, | ||
| nn.GRUCell: nnqd.GRUCell | ||
| nn.GRUCell: nnqd.GRUCell, | ||
| nn.EmbeddingBag: nnqd.EmbeddingBag |
Summary: Convert floating point nn.EmbeddingBag module to nn.quantized.dynamic.EmbeddingBag module Test Plan: python test/test_quantization.py TestDynamicQuantizedModule.test_embedding_bag_api python test/test_quantization.py TestPostTrainingDynamic.test_embedding_quantization Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Convert floating point nn.EmbeddingBag module to nn.quantized.dynamic.EmbeddingBag module Test Plan: python test/test_quantization.py TestDynamicQuantizedModule.test_embedding_bag_api python test/test_quantization.py TestPostTrainingDynamic.test_embedding_quantization Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23200196](https://our.internmc.facebook.com/intern/diff/D23200196) [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Aug 18, 2020
Summary: Convert floating point nn.EmbeddingBag module to nn.quantized.dynamic.EmbeddingBag module Test Plan: python test/test_quantization.py TestDynamicQuantizedModule.test_embedding_bag_api python test/test_quantization.py TestPostTrainingDynamic.test_embedding_quantization Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 220954c Pull Request resolved: #43176
This was referenced Aug 19, 2020
Summary: Convert floating point nn.EmbeddingBag module to nn.quantized.dynamic.EmbeddingBag module Test Plan: python test/test_quantization.py TestDynamicQuantizedModule.test_embedding_bag_api python test/test_quantization.py TestPostTrainingDynamic.test_embedding_quantization Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23200196](https://our.internmc.facebook.com/intern/diff/D23200196) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 3293fdf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Convert floating point nn.EmbeddingBag module to
nn.quantized.dynamic.EmbeddingBag module
Test Plan:
python test/test_quantization.py TestDynamicQuantizedModule.test_embedding_bag_api
python test/test_quantization.py TestPostTrainingDynamic.test_embedding_quantization
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23200196