Skip to content

Add complex number support for binary logical operators #43174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xuhdev wants to merge 6 commits into from
Closed

Add complex number support for binary logical operators #43174

xuhdev wants to merge 6 commits into from

Conversation

@xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Aug 17, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D23684425

This was referenced Aug 17, 2020
Closed
Closed
xuhdev added a commit that referenced this pull request Aug 17, 2020
@xuhdev
Add complex number support for binary logical operators
b605243 
ghstack-source-id: 7c42a64
Pull Request resolved: #43174
@dr-ci
Copy link

dr-ci bot commented Aug 17, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit b951736 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_bazel_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

Sep 23 19:11:34 TIMEOUT: //:optim_test (Summary) 
Sep 23 19:10:15 [ RUN      ] CustomAutogradTest.HookNone 
Sep 23 19:10:15 [       OK ] CustomAutogradTest.HookNone (3 ms) 
Sep 23 19:10:15 [----------] 23 tests from CustomAutogradTest (12983 ms total) 
Sep 23 19:10:15  
Sep 23 19:10:15 [----------] Global test environment tear-down 
Sep 23 19:10:15 [==========] 30 tests from 2 test suites ran. (13073 ms total) 
Sep 23 19:10:15 [  PASSED  ] 30 tests. 
Sep 23 19:10:15 ================================================================================ 
Sep 23 19:11:04 [2,665 / 2,667] 23 / 25 tests; Testing //:optim_test; 465s processwrapper-sandbox ... (2 actions running) 
Sep 23 19:11:34  
Sep 23 19:11:34 TIMEOUT: //:optim_test (Summary) 
Sep 23 19:11:34       /var/lib/jenkins/.cache/bazel/_bazel_jenkins/fdf6d09bf4b4f04a71e2a7dfceb40620/execroot/pytorch/bazel-out/k8-fastbuild/testlogs/optim_test/test.log 
Sep 23 19:11:34 INFO: From Testing //:optim_test: 
Sep 23 19:11:34 ==================== Test output for //:optim_test: 
Sep 23 19:11:34 Running main() from gmock_main.cc 
Sep 23 19:11:34 Note: Google Test filter = -*CUDA 
Sep 23 19:11:34 [==========] Running 33 tests from 1 test suite. 
Sep 23 19:11:34 [----------] Global test environment set-up. 
Sep 23 19:11:34 [----------] 33 tests from OptimTest 
Sep 23 19:11:34 [ RUN      ] OptimTest.OptimizerAccessors 
Sep 23 19:11:34 [       OK ] OptimTest.OptimizerAccessors (2 ms)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 21 times.

@mrshenli mrshenli requested a review from anjali411 August 18, 2020 15:14
@mrshenli mrshenli added module: complex Related to complex number support in PyTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 18, 2020
xuhdev added a commit that referenced this pull request Aug 18, 2020
@xuhdev
Add complex number support for binary logical operators
3012f3c 
ghstack-source-id: 9a42ba4
Pull Request resolved: #43174
@xuhdev xuhdev mentioned this pull request Aug 25, 2020
Closed
@mruberry mruberry self-requested a review September 10, 2020 03:45
mruberry
mruberry approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@codecov
Copy link

codecov bot commented Sep 12, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (gh/xuhdev/85/base@33234b0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             gh/xuhdev/85/base   #43174   +/-   ##
====================================================
  Coverage                     ?   67.98%           
====================================================
  Files                        ?      384           
  Lines                        ?    49567           
  Branches                     ?        0           
====================================================
  Hits                         ?    33697           
  Misses                       ?    15870           
  Partials                     ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33234b0...b951736. Read the comment docs.

@mruberry
Copy link
Collaborator

mruberry commented Sep 23, 2020

Hey @xuhdev, sorry to ping you but would you mind rebasing this PR and the next one in the stack? The internal tools can no longer rebase it automatically. Sorry about that.

@xuhdev
Copy link
Collaborator Author

xuhdev commented Sep 23, 2020

@mruberry Done!

@mruberry
Copy link
Collaborator

mruberry commented Sep 23, 2020

@mruberry Done!

Thank you!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 24, 2020

@mruberry merged this pull request in b470fa4.

@facebook-github-bot facebook-github-bot deleted the gh/xuhdev/85/head branch September 27, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterbell10 peterbell10 peterbell10 approved these changes

@mruberry mruberry mruberry approved these changes

@anjali411 anjali411 Awaiting requested review from anjali411

@zasdfgbnm zasdfgbnm Awaiting requested review from zasdfgbnm

Assignees

No one assigned

Labels

Merged module: complex Related to complex number support in PyTorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@xuhdev @mruberry @facebook-github-bot @peterbell10 @mrshenli @pytorchbot