observers: use clamp instead of min/max in calculate_qparams #43150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The current logic was expensive because it created tensors on CUDA. Switching to clamp since it can work without needing to create tensors. Test Plan: benchmarks Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Aug 17, 2020
jerryzh168
approved these changes
Aug 17, 2020
💊 CI failures summary and remediationsAs of commit 9724ed7 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 1 time. |
Contributor
|
This pull request has been merged in 3264ba0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
The current logic was expensive because it created tensors on CUDA.
Switching to clamp since it can work without needing to create tensors.
yields a ~20% latency improvement on the CUDA microbenchmark for small tensors
(prev diff: P139074571, this diff: P139074706)
Test Plan:
benchmarks
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23170427