Skip to content

observers: make eps a buffer #43149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vkuzo wants to merge 1 commit into from
Closed

observers: make eps a buffer #43149

vkuzo wants to merge 1 commit into from

Conversation

@vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Aug 17, 2020 •
edited
Loading

Stack from ghstack:

Summary:

This value doesn't change, making it a buffer to only pay
the cost of creating a tensor once.

For small tensors microbenchmark on CUDA, ~25% latency improvement
(base: P139074413, this PR: P139074571)

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D23170428

@vkuzo
observers: make eps a buffer
1f48a52 
Summary:

This value doesn't change, making it a buffer to only pay
the cost of creating a tensor once.

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Aug 17, 2020
Closed
Closed
Closed
@dr-ci
Copy link

dr-ci bot commented Aug 17, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 1f48a52 (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Aug 17 13:14:51 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Aug 17 13:14:51 At: 
Aug 17 13:14:51   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(93): serialize 
Aug 17 13:14:51   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(145): serialize 
Aug 17 13:14:51  
Aug 17 13:14:51 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Aug 17 13:14:51  
Aug 17 13:14:51 At: 
Aug 17 13:14:51   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(93): serialize 
Aug 17 13:14:51   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(145): serialize 
Aug 17 13:14:51  
Aug 17 13:14:51 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Aug 17 13:14:51  
Aug 17 13:14:51 At: 
Aug 17 13:14:51   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(93): serialize 
Aug 17 13:14:51   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(145): serialize 
Aug 17 13:14:51  
Aug 17 13:14:51 ok (1.275s) 
Aug 17 13:14:53   test_return_future_remote (__main__.ProcessGroupRpcTestWithSpawn) ... ok (1.371s) 
Aug 17 13:14:54   test_return_local_rrefs (__main__.ProcessGroupRpcTestWithSpawn) ... ok (1.341s) 
Aug 17 13:14:55   test_rpc_return_rref (__main__.ProcessGroupRpcTestWithSpawn) ... ok (1.406s) 
Aug 17 13:15:03   test_rpc_timeouts (__main__.ProcessGroupRpcTestWithSpawn) ... ok (7.809s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 18, 2020

This pull request has been merged in a5dfba0.

@facebook-github-bot facebook-github-bot deleted the gh/vkuzo/126/head branch August 21, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vkuzo @facebook-github-bot @jerryzh168 @mruberry