Skip to content

BUG: make cholesky_solve_out do broadcast, error checking #43137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattip wants to merge 1 commit into from
Closed

BUG: make cholesky_solve_out do broadcast, error checking #43137

mattip wants to merge 1 commit into from

Conversation

@mattip
Copy link
Contributor

@mattip mattip commented Aug 17, 2020

Fixes #42695

test, fix cholesky_solve_out to use error checking and broadcasting from cholesky_solve. Test segfaults before, passes after the fix.

@dr-ci
Copy link

dr-ci bot commented Aug 17, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit a1437f5 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

1 failure confirmed as flaky and can be ignored:

  • pytorch_xla_linux_bionic_py3_6_clang9_test
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@mattip
Copy link
Contributor Author

mattip commented Aug 17, 2020

Is the failure in XLA really due to this PR?

@JackCaoG
Copy link
Collaborator

JackCaoG commented Aug 17, 2020

Is the failure in XLA really due to this PR?

The failure seems irrelevant, do you mind rerun the ci/circleci: pytorch_xla_linux_bionic_py3_6_clang9_test to see if it will pass?

@mattip
Copy link
Contributor Author

mattip commented Aug 18, 2020 •
edited
Loading

Reran the CircleCI build. The previously failing build passes, but now something is off with windows:

FAILED: third_party/ideep/mkl-dnn/src/cpu/CMakeFiles/dnnl_cpu.dir/gemm_convolution_utils.cpp.obj 
fatal error C1001: Internal compiler error.

@mattip mattip mentioned this pull request Aug 25, 2020
Closed
@mattip
Copy link
Contributor Author

mattip commented Aug 25, 2020

Would be nice to get this simple fix merged before the 1.7 release ...

@rgommers
Copy link
Collaborator

rgommers commented Sep 7, 2020

@malfet would you be able to land this one?

facebook-github-bot
facebook-github-bot reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 9, 2020

@malfet merged this pull request in 758c2b9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

segfault and abort in torch.cholesky_solve

7 participants

@mattip @JackCaoG @rgommers @facebook-github-bot @malfet @pytorchbot @mruberry