Skip to content

Enable type-checking of torch.nn.quantized.* modules #43110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guilhermeleobas wants to merge 9 commits into from
Closed

Enable type-checking of torch.nn.quantized.* modules #43110

guilhermeleobas wants to merge 9 commits into from

Conversation

@guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Aug 15, 2020

Fixes #43029

I am not changing the following files in this PR:

@guilhermeleobas guilhermeleobas added the module: typing Related to mypy type annotations label Aug 15, 2020
@guilhermeleobas guilhermeleobas self-assigned this Aug 15, 2020
@dr-ci
Copy link

dr-ci bot commented Aug 15, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 1f98bac (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 49 times.

@rgommers
Copy link
Collaborator

rgommers commented Aug 16, 2020

@guilhermeleobas did you somehow open this PR by mistake? It's the same as gh-43068.

@guilhermeleobas
Copy link
Collaborator Author

guilhermeleobas commented Aug 17, 2020

@rgommers I couldn't revert the submodule update in the other PR. I will close the old one in favor of this.

@guilhermeleobas guilhermeleobas marked this pull request as ready for review August 17, 2020 16:39
@mrshenli mrshenli added oncall: quantization Quantization support in PyTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 18, 2020
rgommers
rgommers requested changes Aug 21, 2020
View reviewed changes
Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @guilhermeleobas. One thing to fix - splitting annotations between a .py and a .pyi file isn't a good idea.

@rgommers
Copy link
Collaborator

rgommers commented Aug 21, 2020

Re last commit: in this case it's a small change so no action needed here, but in general it's better not to mix inlining annotations with changes that fix errors. I edited https://github.com/pytorch/pytorch/wiki/Guide-for-adding-type-annotations-to-PyTorch#setting-up-and-checking-mypy-works to make this clearer.

@guilhermeleobas
Copy link
Collaborator Author

guilhermeleobas commented Aug 21, 2020

Okay, thanks for the heads up. In the future, I will just create another PR if this case comes up again. :)

@guilhermeleobas guilhermeleobas marked this pull request as draft September 8, 2020 23:30
@codecov
Copy link

codecov bot commented Sep 9, 2020 •
edited
Loading

Codecov Report

Merging #43110 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #43110   +/-   ##
=======================================
  Coverage   69.24%   69.25%           
=======================================
  Files         381      381           
  Lines       47577    47582    +5     
=======================================
+ Hits        32947    32951    +4     
- Misses      14630    14631    +1
Impacted Files Coverage Δ
torch/jit/_serialization.py 85.71% <100.00%> (ø)
torch/nn/functional.py 92.22% <100.00%> (ø)
torch/nn/quantized/functional.py 62.41% <100.00%> (+0.54%) ⬆️
torch/nn/quantized/modules/__init__.py 97.05% <100.00%> (+0.18%) ⬆️
torch/nn/quantized/modules/utils.py 86.36% <100.00%> (+0.31%) ⬆️
torch/testing/_internal/expecttest.py 77.55% <0.00%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d62d3...1f98bac. Read the comment docs.

@guilhermeleobas guilhermeleobas marked this pull request as ready for review September 9, 2020 16:13
rgommers
rgommers approved these changes Sep 10, 2020
View reviewed changes
Copy link
Collaborator

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgommers rgommers requested a review from malfet September 10, 2020 20:43
@rgommers rgommers requested a review from ezyang September 25, 2020 17:51
facebook-github-bot
facebook-github-bot reviewed Sep 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 30, 2020

@ezyang merged this pull request in c1e6592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@rgommers rgommers rgommers approved these changes

@malfet malfet Awaiting requested review from malfet

@ezyang ezyang Awaiting requested review from ezyang

Assignees

@guilhermeleobas guilhermeleobas

Labels

Merged module: typing Related to mypy type annotations oncall: quantization Quantization support in PyTorch open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable torch.nn.quantized typechecks during CI

6 participants

@guilhermeleobas @rgommers @facebook-github-bot @mrshenli @pytorchbot @mruberry