Skip to content

Adds arccosh alias for acosh and adds an alias consistency test #43107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mruberry wants to merge 4 commits into from
Closed

Adds arccosh alias for acosh and adds an alias consistency test #43107

mruberry wants to merge 4 commits into from

Conversation

@mruberry
Copy link
Collaborator

@mruberry mruberry commented Aug 15, 2020 •
edited
Loading

This adds the torch.arccosh alias and updates alias testing to validate the consistency of the aliased and original operations. The alias testing is also updated to run on CPU and CUDA, which revealed a memory leak when tracing (see #43119).

@mruberry mruberry requested a review from apaszke as a code owner August 15, 2020 12:15
@mruberry mruberry removed the request for review from apaszke August 15, 2020 12:15
@mruberry mruberry added the module: numpy Related to numpy support, and also numpy compatibility of our operators label Aug 15, 2020
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 15, 2020
@mruberry mruberry requested a review from ngimel August 16, 2020 03:42
@mruberry mruberry changed the title Adds arccosh alias for acosh Adds arccosh alias for acosh and adds an alias consistency test Aug 16, 2020
@dr-ci
Copy link

dr-ci bot commented Aug 16, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3e63325 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Aug 16 09:52:01 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Aug 16 09:52:01 At: 
Aug 16 09:52:01   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(93): serialize 
Aug 16 09:52:01   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(145): serialize 
Aug 16 09:52:01  
Aug 16 09:52:01 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Aug 16 09:52:01  
Aug 16 09:52:01 At: 
Aug 16 09:52:01   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(93): serialize 
Aug 16 09:52:01   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(145): serialize 
Aug 16 09:52:01  
Aug 16 09:52:01 [E request_callback_no_python.cpp:618] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Aug 16 09:52:01  
Aug 16 09:52:01 At: 
Aug 16 09:52:01   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(93): serialize 
Aug 16 09:52:01   /opt/conda/lib/python3.6/site-packages/torch/distributed/rpc/internal.py(145): serialize 
Aug 16 09:52:01  
Aug 16 09:52:01 [W tensorpipe_agent.cpp:576] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Aug 16 09:52:01 [W tensorpipe_agent.cpp:576] RPC agent for worker0 encountered error when reading incoming request from worker2: EOF: end of file (this is expected to happen during shutdown) 
Aug 16 09:52:01 ok (1.013s) 
Aug 16 09:52:02   test_return_future_remote (__main__.TensorPipeRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:576] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Aug 16 09:52:02 [W tensorpipe_agent.cpp:576] RPC agent for worker0 encountered error when reading incoming request from worker3: EOF: end of file (this is expected to happen during shutdown)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

ngimel
ngimel reviewed Aug 16, 2020
View reviewed changes
facebook-github-bot
facebook-github-bot reviewed Aug 16, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 17, 2020

@mruberry merged this pull request in e2eb0cb.

@mruberry mruberry deleted the trig_aliases branch August 21, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

Merged module: numpy Related to numpy support, and also numpy compatibility of our operators oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mruberry @facebook-github-bot @ngimel