Skip to content

Updates torch.clone documentation to be consistent with other functions #43098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mruberry wants to merge 5 commits into from
Closed

Updates torch.clone documentation to be consistent with other functions #43098

mruberry wants to merge 5 commits into from

Conversation

@mruberry
Copy link
Collaborator

@mruberry mruberry commented Aug 15, 2020

torch.clone exists but was undocumented, and the method incorrectly listed memory_format as a positional argument. This:

  • documents torch.clone
  • lists memory_format as a keyword-only argument
  • wordsmiths the documentation

@mruberry mruberry requested a review from albanD August 15, 2020 06:30
@dr-ci
Copy link

dr-ci bot commented Aug 15, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d33669e (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

OpenSSL.SSL.SysCallError: (10054, 'WSAECONNRESET') 
 
# >>>>>>>>>>>>>>>>>>>>>> ERROR REPORT <<<<<<<<<<<<<<<<<<<<<< 
 
    Traceback (most recent call last): 
      File "C:\Jenkins\Miniconda3\lib\site-packages\urllib3\contrib\pyopenssl.py", line 313, in recv_into 
        return self.connection.recv_into(*args, **kwargs) 
      File "C:\Jenkins\Miniconda3\lib\site-packages\OpenSSL\SSL.py", line 1840, in recv_into 
        self._raise_ssl_error(self._ssl, result) 
      File "C:\Jenkins\Miniconda3\lib\site-packages\OpenSSL\SSL.py", line 1663, in _raise_ssl_error 
        raise SysCallError(errno, errorcode.get(errno)) 
    OpenSSL.SSL.SysCallError: (10054, 'WSAECONNRESET') 
     
    During handling of the above exception, another exception occurred: 
     
    Traceback (most recent call last): 
      File "C:\Jenkins\Miniconda3\lib\site-packages\urllib3\response.py", line 425, in _error_catcher 
        yield 
      File "C:\Jenkins\Miniconda3\lib\site-packages\urllib3\response.py", line 752, in read_chunked 
        self._update_chunk_length() 
      File "C:\Jenkins\Miniconda3\lib\site-packages\urllib3\response.py", line 682, in _update_chunk_length 
        line = self._fp.fp.readline()
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 12 times.

albanD
albanD approved these changes Aug 15, 2020
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

facebook-github-bot
facebook-github-bot reviewed Aug 16, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 16, 2020

@mruberry merged this pull request in d4c5f56.

@facebook-github-bot facebook-github-bot deleted the clone_fn branch January 27, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mruberry @facebook-github-bot @albanD