Skip to content

Add type annotations for torch.nn.utils.* #43080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guilhermeleobas wants to merge 10 commits into from
Closed

Add type annotations for torch.nn.utils.* #43080

guilhermeleobas wants to merge 10 commits into from

Conversation

@guilhermeleobas
Copy link
Collaborator

@guilhermeleobas guilhermeleobas commented Aug 14, 2020 •
edited by rgommers
Loading

Fixes #43013

Redo of gh-42954

@guilhermeleobas guilhermeleobas added the module: typing Related to mypy type annotations label Aug 14, 2020
@guilhermeleobas guilhermeleobas self-assigned this Aug 14, 2020
@dr-ci
Copy link

dr-ci bot commented Aug 14, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit cb4f89b (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_libtorch_linux_xenial_cuda11_0_cudnn8_py3_gcc7_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

MakeTmp/CheckSymbolExists.c: In function \'main\':\n/var/lib/jenkins/cpp-build/caffe2/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: \'strtod_l\' undeclared (first use in this function); did you mean \'strtoull\'?\n return ((int*)(&strtod_l))[argc];\n ^~~~~~~~\n strtoull\n/var/lib/jenkins/cpp-build/caffe2/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: note: each undeclared identifier is reported only once for each function it appears in\n" } 
Sep 14 16:14:02 -- Set runtime path of "/var/lib/jenkins/workspace/torch/bin/test_cpp_rpc" to "$ORIGIN:/usr/local/cuda/lib64:/opt/conda/lib" 
Sep 14 16:14:02 -- Set runtime path of "/var/lib/jenkins/workspace/torch/bin/test_api" to "$ORIGIN:/usr/local/cuda/lib64:/opt/conda/lib" 
Sep 14 16:14:02 -- Set runtime path of "/var/lib/jenkins/workspace/torch/bin/test_dist_autograd" to "$ORIGIN:/usr/local/cuda/lib64:/opt/conda/lib" 
Sep 14 16:14:02 -- Set runtime path of "/var/lib/jenkins/workspace/torch/lib/libcaffe2_detectron_ops_gpu.so" to "$ORIGIN:/usr/local/cuda/lib64:/opt/conda/lib" 
Sep 14 16:14:02 -- Set runtime path of "/var/lib/jenkins/workspace/torch/lib/libcaffe2_module_test_dynamic.so" to "$ORIGIN:/opt/conda/lib:/usr/local/cuda/lib64" 
_JNI=ON -DBUILD_PYTHON=False -DBUILD_TEST=True -DCMAKE_BUILD_TYPE=Debug -DCMAKE_INSTALL_PREFIX=/var/lib/jenkins/workspace/torch -DCMAKE_PREFIX_PATH=/opt/conda/lib/python3.6/site-packages -DCUDA_NVCC_EXECUTABLE=/opt/cache/lib/nvcc -DJAVA_HOME=/usr/local -DNUMPY_INCLUDE_DIR=/opt/conda/lib/python3.6/site-packages/numpy/core/include -DPYTHON_EXECUTABLE=/opt/conda/bin/python -DPYTHON_INCLUDE_DIR=/opt/conda/include/python3.6m -DUSE_LLVM=/opt/llvm -DUSE_NUMPY=True -DWERROR=1 /var/lib/jenkins/workspace 
Sep 14 16:14:02 cmake --build . --target install --config Debug -- -j 3 
Sep 14 16:14:02 ~/workspace 
Sep 14 16:14:02 EXITED_USER_LAND 
Sep 14 16:14:02 =================== sccache compilation log =================== 
akeTmp/CheckSymbolExists.c: In function \'main\':\n/var/lib/jenkins/cpp-build/caffe2/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: \'strtod_l\' undeclared (first use in this function); did you mean \'strtoull\'?\n   return ((int*)(&strtod_l))[argc];\n                   ^~~~~~~~\n                   strtoull\n/var/lib/jenkins/cpp-build/caffe2/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: note: each undeclared identifier is reported only once for each function it appears in\n" } 
Sep 14 16:14:02  
Sep 14 16:14:02 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Sep 14 16:14:02 Compile requests              9953 
Sep 14 16:14:02 Compile requests executed     4237 
Sep 14 16:14:02 Cache hits                    4006 
Sep 14 16:14:02 Cache misses                   218 
Sep 14 16:14:02 Cache timeouts                   0 
Sep 14 16:14:02 Cache read errors                0 
Sep 14 16:14:02 Forced recaches                  0 
Sep 14 16:14:02 Cache write errors               0
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 23 times.

rgommers
rgommers reviewed Aug 16, 2020
View reviewed changes
@guilhermeleobas guilhermeleobas marked this pull request as ready for review August 17, 2020 20:49
@mrshenli mrshenli added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 18, 2020
@mrshenli mrshenli requested a review from malfet August 18, 2020 17:42
@rgommers rgommers removed the request for review from apaszke August 21, 2020 15:38
facebook-github-bot
facebook-github-bot reviewed Sep 14, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 15, 2020

@malfet merged this pull request in e107ef5.

xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
@guilhermeleobas @xuzhao9
Add type annotations for torch.nn.utils.* (#43080)
0b910a9 
Summary:
Fixes #43013

Redo of gh-42954

Pull Request resolved: #43080

Reviewed By: albanD

Differential Revision: D23681334

Pulled By: malfet

fbshipit-source-id: 20ec78aa3bfecb7acffc12eb89d3ad833024394c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@rgommers rgommers rgommers approved these changes

@malfet malfet malfet approved these changes

Assignees

@guilhermeleobas guilhermeleobas

Labels

Merged module: typing Related to mypy type annotations open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable torch.nn.utils typechecks during CI

7 participants

@guilhermeleobas @facebook-github-bot @rgommers @malfet @mrshenli @pytorchbot @mruberry