2 Bit Embedding Conversion Operator support. #43077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23143262 |
💊 CI failures summary and remediationsAs of commit 9e97a5d (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 ongoing upstream failure:These were probably caused by upstream breakages that are not fixed yet:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 10 times. |
supriyar
reviewed
Aug 17, 2020
supriyar
reviewed
Aug 17, 2020
supriyar
reviewed
Aug 18, 2020
supriyar
approved these changes
Aug 18, 2020
Contributor
supriyar
left a comment
supriyar
left a comment
There was a problem hiding this comment.
Looks good, left some minor comments.
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23143262 |
radkris-git
force-pushed
the
export-D23143262
branch
from
e4abb76 to
4081495
Compare
Summary: Pull Request resolved: pytorch#43077 2 Bit Embedding weight conversion operation is quite similar to 4 bit embedding weight conversion. The diff contains both the 1. 2bit packing op `embedding_bag_2bit_prepack`. 2. 2bit unpacking op `embedding_bag_2bit_unpack`. Comments about the op are inline with the op definition. Test Plan: buck test caffe2/test:quantization -- test_embedding_bag_2bit_unpack Reviewed By: supriyar Differential Revision: D23143262 fbshipit-source-id: 97cd6da969abafb5d302b3150ba5349117f22b8a
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D23143262 |
radkris-git
force-pushed
the
export-D23143262
branch
from
4081495 to
9e97a5d
Compare
Contributor
|
This pull request has been merged in fa6b34b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
2 Bit Embedding weight conversion operation is quite similar to
4 bit embedding weight conversion.
The diff contains both the
embedding_bag_2bit_prepack.embedding_bag_2bit_unpack.Comments about the op are inline with the op definition.
Test Plan: buck test caffe2/test:quantization -- test_embedding_bag_2bit_unpack
Differential Revision: D23143262