Issue 43057 #43063
Closed
Issue 43057 #43063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small change that adds a docstring that can be found with `getattr(nn.Module, nn.Module.forward.__name__, None).__doc__` Closes pytorch#43057
mruberry
reviewed
Aug 14, 2020
torch/nn/modules/module.py
Outdated
| # forward as a value, rather than a function. See also | ||
| # https://github.com/python/mypy/issues/8795 | ||
| def _forward_unimplemented(self, *input: Any) -> None: | ||
| r"""Forward defines the computation performed at every call. |
Collaborator
There was a problem hiding this comment.
Instead of making this a docstring, I would have expected the string next to forward to be set as the docstring on the forward object and for this to be unchanged. Don't you want the other string as the docstring?
Contributor
Author
There was a problem hiding this comment.
thanks for the advice. I wasn't sure how best to do this as I was reluctant to move the docstring for forward away from the definition of forward.
I've made that change.
Collaborator
|
@ezyang Looks like you last moved this doc string, want to sanity check this change? |
ezyang
approved these changes
Aug 17, 2020
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change that adds a docstring that can be found with
getattr(nn.Module, nn.Module.forward.__name__, None).__doc__Fixes #43057