[rpc][jit] support remote call in TorchScript #43046
Conversation
[ghstack-poisoned]
wanchaol
requested review from
apaszke,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 075425e (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedcodecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 61 times. |
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
wanchaol
changed the title
Differential Revision: [D23621108](https://our.internmc.facebook.com/intern/diff/D23621108) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/wanchaol/122/base #43046 +/- ##
========================================================
- Coverage 68.06% 68.06% -0.01%
========================================================
Files 382 382
Lines 49461 49465 +4
========================================================
+ Hits 33667 33669 +2
- Misses 15794 15796 +2
Continue to review full report at Codecov.
|
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this!
| } else { | ||
| output_type = returns[0].type(); | ||
| } | ||
| rpc_node_output->setType(output_type); |
There was a problem hiding this comment.
This looks a little different from the previous version. Prior to this change, if rpc_op == prim::rpc_sync, rpc_node_output->setType is not called. Is it true that, by default, its type is already returns[0].type()?
There was a problem hiding this comment.
good catch, no it's not automatically set I think, let me change it in previous PR
Differential Revision: [D23621108](https://our.internmc.facebook.com/intern/diff/D23621108) [ghstack-poisoned]
Summary: Pull Request resolved: #43046 Test Plan: Imported from OSS Reviewed By: mrshenli Differential Revision: D23621108 Pulled By: wanchaol fbshipit-source-id: e8152c6cdd3831f32d72d46ac86ce22f3f13c651
Stack from ghstack:
Differential Revision: D23621108