[rpc][jit] support rpc_sync in TorchScript #43043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add the support for rpc_sync in TorchScript in a way similar to rpc_async [ghstack-poisoned]
wanchaol
requested review from
apaszke,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 0565576 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedcodecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 56 times. |
This add the support for rpc_sync in TorchScript in a way similar to rpc_async [ghstack-poisoned]
This add the support for rpc_sync in TorchScript in a way similar to rpc_async [ghstack-poisoned]
mrshenli
approved these changes
Aug 19, 2020
Contributor
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this!
It will be great if we can also cover the case where user function throws, but it can be added in follow up PRs.
| py::module::import("torch.distributed.rpc").attr("rpc_async").ptr()) { | ||
| return SpecialFormValue::create(prim::rpc_async); | ||
| } else if ( | ||
| // RPC module is only avaialble when build flag "USE_DISTRIBUTED" is on. |
Contributor
There was a problem hiding this comment.
redundant space after "available"
| } else if ( | ||
| // RPC module is only avaialble when build flag "USE_DISTRIBUTED" is on. | ||
| obj.ptr() == | ||
| py::module::import("torch.distributed.rpc").attr("rpc_sync").ptr()) { |
Contributor
There was a problem hiding this comment.
is the indent here intentional?
Collaborator
Author
There was a problem hiding this comment.
it's formatted by clang-format (and stay aligned with the above rpc_async op)
Comment on lines
148
to
149
| futureIValuePtr->wait(); | ||
| auto res = futureIValuePtr->value(); |
Contributor
There was a problem hiding this comment.
These could throw error. Is that OK?
Collaborator
Author
There was a problem hiding this comment.
good catch! handled the error.
This add the support for rpc_sync in TorchScript in a way similar to rpc_async [ghstack-poisoned]
This add the support for rpc_sync in TorchScript in a way similar to rpc_async Differential Revision: [D23252039](https://our.internmc.facebook.com/intern/diff/D23252039) [ghstack-poisoned]
This add the support for rpc_sync in TorchScript in a way similar to rpc_async Differential Revision: [D23252039](https://our.internmc.facebook.com/intern/diff/D23252039) [ghstack-poisoned]
This add the support for rpc_sync in TorchScript in a way similar to rpc_async Differential Revision: [D23252039](https://our.internmc.facebook.com/intern/diff/D23252039) [ghstack-poisoned]
This add the support for rpc_sync in TorchScript in a way similar to rpc_async Differential Revision: [D23252039](https://our.internmc.facebook.com/intern/diff/D23252039) [ghstack-poisoned]
This add the support for rpc_sync in TorchScript in a way similar to rpc_async Differential Revision: [D23252039](https://our.internmc.facebook.com/intern/diff/D23252039) [ghstack-poisoned]
This add the support for rpc_sync in TorchScript in a way similar to rpc_async Differential Revision: [D23252039](https://our.internmc.facebook.com/intern/diff/D23252039) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/wanchaol/121/base #43043 +/- ##
=====================================================
Coverage 68.05% 68.06%
=====================================================
Files 382 382
Lines 49468 49461 -7
=====================================================
Hits 33667 33667
+ Misses 15801 15794 -7
Continue to review full report at Codecov.
|
This add the support for rpc_sync in TorchScript in a way similar to rpc_async Differential Revision: [D23252039](https://our.internmc.facebook.com/intern/diff/D23252039) [ghstack-poisoned]
Contributor
xuzhao9
pushed a commit
that referenced
this pull request
Sep 18, 2020
Summary: Pull Request resolved: #43043 This add the support for rpc_sync in TorchScript in a way similar to rpc_async Test Plan: Imported from OSS Reviewed By: mrshenli Differential Revision: D23252039 Pulled By: wanchaol fbshipit-source-id: 8a05329cb8a24079b2863178b73087d47273914c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This add the support for rpc_sync in TorchScript in a way similar to
rpc_async
Differential Revision: D23252039