Enable torch.utils typechecks #42960

malfet · 2020-08-13T01:41:06Z

Fix typos in torch.utils/_benchmark/README.md
Add empty init.py to examples folder to make example invocations from README.md correct
Fixed uniform distribution logic generation when mixval and maxval are None

Fixes #42984

facebook-github-bot

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

dr-ci · 2020-08-13T02:09:55Z

💊 CI failures summary and remediations

As of commit 144609e (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

3/3 broken upstream at merge base 0ff51ac on Aug 13 from 5:14am to 11:40am PDT (11 commits; d39cb84 - fd5ed4b)

🚧 3 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

caffe2_onnx_ort1_py3_6_clang7_ubuntu16_04_test on Aug 13 from 5:14am to 11:40am PDT (11 commits; d39cb84 - fd5ed4b)
- 🔁 rerun
caffe2_onnx_ort2_py3_6_clang7_ubuntu16_04_test on Aug 13 from 5:14am to 11:40am PDT (11 commits; d39cb84 - fd5ed4b)
- 🔁 rerun
caffe2_onnx_main_py3_6_clang7_ubuntu16_04_test on Aug 13 from 5:14am to 11:40am PDT (11 commits; d39cb84 - fd5ed4b)
- 🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 16 times.

facebook-github-bot

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Add empty __init__.py to examples folder to make example invocations from README.md correct

Fixed uniform distribution logic generation when mixval and maxval are None Added typing annotations to few methods

facebook-github-bot

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-08-14T00:13:04Z

@malfet merged this pull request in 6753157.

malfet added module: typing Related to mypy type annotations triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Aug 13, 2020

malfet requested review from ezyang, rgommers, seemethere and t-vi August 13, 2020 01:41

malfet requested review from fmassa, goldsborough and soumith as code owners August 13, 2020 01:41

malfet force-pushed the malfet/enable-torch.utils-typechecks branch 2 times, most recently from 048944e to 98796e8 Compare August 13, 2020 02:09