[quant][pyper] Make offsets an optional paramter in the qembedding_bag op #42924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g op Summary: offsets is an optional paramter in the python module currently. So we update the operator to follow suit in order to avoid bad optional access Test Plan: python test/test_quantization.py TestQuantizeDynamicJitOps.test_embedding_bag Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 2e5017b (more details on the Dr. CI page):
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
radkris-git
approved these changes
Aug 12, 2020
…mbedding_bag op" Summary: offsets is an optional paramter in the python module currently. So we update the operator to follow suit in order to avoid bad optional access Test Plan: python test/test_quantization.py TestQuantizeDynamicJitOps.test_embedding_bag Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D23081152](https://our.internmc.facebook.com/intern/diff/D23081152) [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Aug 12, 2020
…g op Summary: offsets is an optional paramter in the python module currently. So we update the operator to follow suit in order to avoid bad optional access Test Plan: python test/test_quantization.py TestQuantizeDynamicJitOps.test_embedding_bag Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 229b08b Pull Request resolved: #42924
Contributor
|
This pull request has been merged in c9dcc83. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
offsets is an optional paramter in the python module currently. So we update the operator to follow suit
in order to avoid bad optional access
Test Plan:
python test/test_quantization.py TestQuantizeDynamicJitOps.test_embedding_bag
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23081152